Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

베이스 토스트 굽기 (feat: recoil) #78

Merged
merged 2 commits into from
Jan 15, 2022
Merged

베이스 토스트 굽기 (feat: recoil) #78

merged 2 commits into from
Jan 15, 2022

Conversation

SeojinSeojin
Copy link
Member

⛓ Related Issues

📋 작업 내용

  • 토스트 쓰는 훅 만들기
  • 토스트 퍼블리싱하기

📌 PR Point

토스트 사용 방법

const { fireToast } = useToast();

fireToast({ content:'방가방가' });

토스트의 props

이름 타입 역할
content string 토스트에 들어갈 내용
duration number? 토스트가 지속되는 시간 (default=1초)
bottom number? 토스트의 바닥으로부터의 거리 (default=26px)

@SeojinSeojin SeojinSeojin added feature 🎄 기능 개발 layout 🍃 레이아웃 개발 labels Jan 15, 2022
@SeojinSeojin SeojinSeojin self-assigned this Jan 15, 2022
@SeojinSeojin
Copy link
Member Author

울 웹쁜이 고생많았어 ! 여기서 미리보기로 보면서 쉬어~ 다른 웹쁜이들한테도 자랑해줘~

100Gyeon
100Gyeon approved these changes Jan 15, 2022
View reviewed changes
Copy link
Member

@100Gyeon 100Gyeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

웹에서도 토스트를 추가할 줄이야 아주 좋아용 👍

src/presentation/components/common/Toast/Item/style.ts Outdated
Comment on lines 6 to 7
margin-right: 20px;
margin-left: 20px;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

한 줄로 쓰려면 margin: 0 20px;로 가능 ~~!

@SeojinSeojin
Copy link
Member Author

울 웹쁜이 고생많았어 ! 여기서 미리보기로 보면서 쉬어~ 다른 웹쁜이들한테도 자랑해줘~

NamJwong
NamJwong approved these changes Jan 15, 2022
View reviewed changes
Copy link
Member

@NamJwong NamJwong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

어?!
는 대박 진짜 잘함! ㅎ,ㅎ

@SeojinSeojin SeojinSeojin merged commit 0e22eae into dev Jan 15, 2022
@SeojinSeojin SeojinSeojin deleted the feat/#76 branch January 15, 2022 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hyoin-Kim Hyoin-Kim Hyoin-Kim approved these changes

@100Gyeon 100Gyeon 100Gyeon approved these changes

@NamJwong NamJwong NamJwong approved these changes

Assignees

@SeojinSeojin SeojinSeojin

Labels
feature 🎄 기능 개발 layout 🍃 레이아웃 개발
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

토스트 굽기
4 participants
@SeojinSeojin @Hyoin-Kim @100Gyeon @NamJwong