너소서 폼 작성 부분 #87
Merged
너소서 폼 작성 부분 #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
울 웹쁜이 고생많았어 ! 여기서 미리보기로 보면서 쉬어~ 다른 웹쁜이들한테도 자랑해줘~ |
100Gyeon
approved these changes
Jan 16, 2022
|
울 웹쁜이 고생많았어 ! 여기서 미리보기로 보면서 쉬어~ 다른 웹쁜이들한테도 자랑해줘~ |
Hyoin-Kim
reviewed
Jan 16, 2022
| }; | ||
|
|
||
| const postFormAnswer = async (body: NeososeoAnswerData) => { | ||
| console.log(body); |
Comment on lines
+12
to
+17
| <StNeososeoFormHeader> | ||
| <div>{title}</div> | ||
| <div> | ||
| <img src={image} alt={title} /> | ||
| </div> | ||
| </StNeososeoFormHeader> |
There was a problem hiding this comment.
이코드 제가 짠코드 과감히 버리고 재사용해도될까요 ?
There was a problem hiding this comment.
요 부분이 맞져?
그럼 되옵니다!!
| setNeososeoAnswer((prev) => ({ ...prev, keyword: keywordList.map((k) => k.id) })); | ||
| }, [keywordList]); | ||
|
|
||
| if (!neososeoFormData) return <></>; |
There was a problem hiding this comment.
요건 무슨 코드이징?.? (진짜몰라서 물어보는거..)
There was a problem hiding this comment.
너소서 폼데이터를 API로 받아올 때 없으면 아무것도 안 렌더링되게 일단 해둔 것!!!
| <ImmutableKeywordList keywordList={keywordList} onItemClick={() => null} /> | ||
| </StKeywordListWrapper> | ||
| </div> | ||
| <StButton onClick={postNeososeoForm}>답변 작성하기</StButton> |
There was a problem hiding this comment.
필수값이 빈값이면 버튼 disalbed하는거 넣어주는건 어떨까!!
| <div> | ||
| <div>{neososeoFormData.content}</div> | ||
| </div> | ||
| <StButton onClick={() => navigate('intro')}>답변 작성하기</StButton> |
Comment on lines
+36
to
+37
| <span>Q.</span> | ||
| <span>{neososeoFormData.content}</span> |
There was a problem hiding this comment.
나는 <p>Q.<p> 이랬는데 <span>태그로 바꿀까?
There was a problem hiding this comment.
옹 p는 넓은 친구고 span은 좁을 수도 있는 친구라 span이 조을 것 같아..!!
Hyoin-Kim
approved these changes
Jan 16, 2022
|
울 웹쁜이 고생많았어 ! 여기서 미리보기로 보면서 쉬어~ 다른 웹쁜이들한테도 자랑해줘~ |
|
울 웹쁜이 고생많았어 ! 여기서 미리보기로 보면서 쉬어~ 다른 웹쁜이들한테도 자랑해줘~ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
⛓ Related Issues
📋 작업 내용
📌 PR Point
👀 스크린샷 / GIF / 링크