Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SettingForm 优化 #125

Merged
merged 6 commits into from
Apr 3, 2024
Merged

SettingForm 优化 #125

merged 6 commits into from
Apr 3, 2024

Conversation

BoBoooooo
Copy link
Contributor

@BoBoooooo BoBoooooo commented Mar 26, 2024 •
edited
Loading

  • FormGroupHeader 默认吸顶（仅一级 Header 支持）
  • expressionSetter
    • autoCompleteOptions 新增可视化下拉框面板
  • actionSetter
    • 新增 consoleLog 打印事件参数快捷选项

@BoBoooooo BoBoooooo changed the title eventSetter & renderPropsSetter 默认激活表达式面板 SettingForm 优化 Mar 26, 2024
@BoBoooooo BoBoooooo marked this pull request as ready for review March 26, 2024 06:37
wwsun
wwsun reviewed Mar 27, 2024
View reviewed changes
packages/setting-form/src/form-item.tsx Outdated
@@ -34,6 +34,7 @@ export interface FormItemComponentProps<T = any> {
onChange: (value: T, detail?: SetterOnChangeDetailType) => void;
readOnly?: boolean;
disabled?: boolean;
toggleIsVariable?: () => void;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

和 disableVariableSetter 区别是啥？

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

选中后自动切换到 源码模式

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这部分逻辑已经提供了支持，无需增加 toggleIsVariable 的逻辑。先拿掉吧。其他都没啥问题。

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@wwsun wwsun merged commit 3f42516 into NetEase:main Apr 3, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wwsun wwsun wwsun left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BoBoooooo @wwsun