Added EurekaVipAddressRoundRobinWithAzAffinityService to the eureka s… #77
Conversation
Codecov Report
@@ Coverage Diff @@
## master #77 +/- ##
============================================
+ Coverage 90.76% 90.83% +0.07%
- Complexity 2035 2042 +7
============================================
Files 143 145 +2
Lines 5953 5969 +16
Branches 782 784 +2
============================================
+ Hits 5403 5422 +19
+ Misses 370 367 -3
Partials 180 180
Continue to review full report at Codecov.
|
| * @return The *next* active {@link InstanceInfo} that should be called for the given VIP name (using a round-robin | ||
| * strategy with current availability zone affinity), or an empty Optional if no active instances were found. | ||
| */ | ||
| public Optional<InstanceInfo> getActiveInstanceInfoForVipAddressBlocking(String vipName) { |
There was a problem hiding this comment.
Missing @Override here and elsewhere I think?
| import java.util.function.Supplier; | ||
| import java.util.stream.Collectors; | ||
| /** | ||
| * Service that uses the Eureka discovery client to provide all the instances associated with a VIP name ({@link |
There was a problem hiding this comment.
Adjust the javadocs to point out why this is different than the other impl (and maybe adjust the other impl's javadocs to point here if you need AZ affinity).
| * <p/> | ||
| * TODO: See if Netflix has a newer version of the Eureka client that allows for async nonblocking retrieval via futures. | ||
| */ | ||
| List<InstanceInfo> getActiveInstanceInfosForVipAddressBlocking(String vipName) { |
There was a problem hiding this comment.
I think the public scope on the methods here has been lost.
There was a problem hiding this comment.
Thanks for catching that. I had initially set this as an interface but switched it to an abstract class and forgot to put back in the public keywords
cjha
force-pushed
the
add-eureka-az-affinity-round-robin-service
branch
from
67b9756 to
a7ccb19
Compare
|
I uploaded a new commit addressing the comments. |
…ub-module. This service will round-robin requests to instances in the same availability zone as the current server. If there are no instances in the current availability zone, it will round-robin instances in all availability zones. Routing requests this way has the advantage of lower response times and lower data transfer costs.
cjha
force-pushed
the
add-eureka-az-affinity-round-robin-service
branch
from
a7ccb19 to
e861328
Compare
|
Great, thank you @cjha this is a really good feature! |
…ub-module. This service will round-robin requests to instances in the same availability zone as the current server. If there are no instances in the current availability zone, it will round-robin instances in all availability zones. Routing requests this way has the advantage of lower response times and lower data transfer costs.