Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

treewide: delete opentracing #265032

Closed
wants to merge 1 commit into from
Closed

treewide: delete opentracing #265032

wants to merge 1 commit into from

Conversation

AndersonTorres
Copy link
Member

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 8.has: clean-up 8.has: package (new) This PR adds a new package labels Nov 3, 2023
@ofborg ofborg bot requested a review from samuela November 3, 2023 14:43
samuela
samuela reviewed Nov 3, 2023
View reviewed changes
Copy link
Member

@samuela samuela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as long as python3Packages.ariadne still builds successfully

@ofborg ofborg bot requested a review from samuela November 3, 2023 19:46
@AndersonTorres AndersonTorres marked this pull request as ready for review November 3, 2023 21:20
@AndersonTorres
Copy link
Member Author

AndersonTorres commented Nov 4, 2023 •
edited
Loading

LGTM as long as python3Packages.ariadne still builds successfully

Unfortunately no. I will draft this.

Maybe it can be fixed:

mirumee/ariadne#649

@AndersonTorres AndersonTorres marked this pull request as draft November 4, 2023 15:06
@samuela
Copy link
Member

samuela commented Nov 4, 2023

@AndersonTorres It looks like it's only used in nativeCheckInputs. Perhaps we could disable those tests and leave a code comment pointing to that issue and this PR?

@AndersonTorres
Copy link
Member Author

I was reading the Ariadne code, and opentracing was used only for testing.

@AndersonTorres
Copy link
Member Author

@ofborg build python3Packages.ariadne

@AndersonTorres
Copy link
Member Author

It will need strong patches!

@AndersonTorres
Copy link
Member Author

Now it was solved!

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux and removed 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Dec 4, 2023
@AndersonTorres AndersonTorres deleted the drop-opentracing branch December 10, 2023 01:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samuela samuela Awaiting requested review from samuela

@RaitoBezarius RaitoBezarius Awaiting requested review from RaitoBezarius

Assignees
No one assigned
Labels
6.topic: python 8.has: clean-up 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AndersonTorres @samuela