Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Controller IO Heating Room #2950

Merged
merged 2 commits into from
Jan 6, 2025
Merged

Conversation

sfeilmeier
Copy link
Contributor

Controls electric floor and infrared heating in a room.

Additionally:

  • Improvements to JSCalendar (this is the first Controller that uses a JSCalendar schedule configuration... more to come!)
  • Improvements to core components (JsonUtils, Thermometer, DummyThermometer, DummyInputOutput, etc.)

The Controller activates electric floor and infrared heating in a room in order to keep a configured LOW or HIGH temperature.
The timings of LOW or HIGH are configured via a schedule configuration parameter.
It holds a JsonArray with JSCalendar information, e.g.

[
   {
      "@type":"Task",
      "start":"05:30:00",
      "duration":"PT2H30M",
      "recurrenceRules":[
         {
            "frequency":"weekly",
            "byDay":[
               "mo",
               "tu",
               "we",
               "th",
               "fr"
            ]
         }
      ]
   },
   {
      "@type":"Task",
      "start":"08:00:00",
      "duration":"PT16H",
      "recurrenceRules":[
         {
            "frequency":"weekly",
            "byDay":[
               "sa",
               "su"
            ]
         }
      ]
   }
]

or simply:

[
   {
      "@type":"Task",
      "start":"19:00:00",
      "duration":"PT12H",
      "recurrenceRules":[
         {
            "frequency":"daily"
         }
      ]
   }
]

Controls electric floor and infrared heating in a room.

The Controller activates electric floor and infrared heating in a room in order to keep a configured LOW or HIGH temperature. The timings of LOW or HIGH are configured via a `schedule` configuration parameter.

Additionally:
- Improvements to JSCalendar (this is the first Controller that uses a JSCalendar schedule configuration... more to come!)
- Improvements to core components (JsonUtils, Thermometer, DummyThermometer, DummyInputOutput, etc.)
Copy link

codecov bot commented Jan 6, 2025

Codecov Report

Attention: Patch coverage is 80.42169% with 65 lines in your changes missing coverage. Please review.

Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #2950      +/-   ##
=============================================
+ Coverage      57.01%   57.08%   +0.08%     
- Complexity      9659     9731      +72     
=============================================
  Files           2262     2266       +4     
  Lines          96538    96819     +281     
  Branches        7126     7163      +37     
=============================================
+ Hits           55031    55263     +232     
- Misses         39460    39494      +34     
- Partials        2047     2062      +15     

@sfeilmeier sfeilmeier merged commit 3f12b22 into develop Jan 6, 2025
6 of 7 checks passed
@sfeilmeier sfeilmeier deleted the feature/controller-heating-room branch January 6, 2025 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant