Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

player goes lightspeed when bunny hop is deactivated #362

Open
limflag opened this issue Jan 24, 2025 · 3 comments
Open

player goes lightspeed when bunny hop is deactivated #362

limflag opened this issue Jan 24, 2025 · 3 comments
Labels
bug Something isn't working

Comments

@limflag
Copy link

limflag commented Jan 24, 2025

hi!
was making some tests on the framework and discovered by accident a bug where the player if sprint then jump, with the bunnyHop disabled, the speed after landing just goes insanely high
checked some codes from the player controller and found that may be that

Image

Cogito 1.0.2 and Godot 4.3 running on a Ubuntu 24.04

Description:
Looks like the SPRINTING_SPEED variable increment itself to a point where the player become faster than it should be

Reproduction steps:
Disable the player bunnyHop
Tries to sprint and jump

Expected behavior:
Player will be in a super high speed mode, like my SPRINTING_SPEED var got to 24, was set to 6 before

Screenshots:
uploaded before in first paragraph

2025-01-24.13-35-42.mp4
@limflag limflag added the bug Something isn't working label Jan 24, 2025
@limflag
Copy link
Author

limflag commented Jan 24, 2025

kinda fixed it when i removed the increment on the elif clause

   elif:
       SPRINTING_SPEED = SPRINTING_SPEED

probably just removing the clause should work too

Vroodot added a commit to Vroodot/Cogito that referenced this issue Feb 12, 2025
Commented out the cause of the bug from issue Phazorknight#362 
Since we aren't adjusting the `SPRINTING_SPEED` at any point, there's no need to add it back to itself.

If adding a Jump Acceleration is the desired behavior, I detailed how we could achieve that in the comments.

Phazorknight#362
@Vroodot
Copy link
Contributor

Vroodot commented Feb 12, 2025

Added this as a small PR for the main build since its only a bug-fix 👍

I'm helping work on an updated Player Controller, so if you note any other issues please feel free to let me know

@Vroodot
Copy link
Contributor

Vroodot commented Feb 13, 2025

@Phazorknight

Since you accepted the PR, feel free to close this issue whenever

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants