Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IsActiveDeviceType: poll only matching device type #492

Closed
wants to merge 1 commit into from
Closed

IsActiveDeviceType: poll only matching device type #492

wants to merge 1 commit into from

Conversation

Portisch
Copy link

@Portisch Portisch commented Mar 3, 2020

There is a delay of 10-30 seconds until key press transfer get functional when starting Kodi with libCEC. The reason is the function IsActiveDeviceType because it poll all nodes on the CEC bus. This commit will filter the devices by given type before polling to minimize the delay.

Be lenient with me, I am not so familiar with the libCEC source and I don't have the hardware to test it.
So if this will not work please help to find another way to fix this annoying startup delay.

@Portisch
Copy link
Author

Portisch commented Mar 7, 2020

I fixed the GetStatus() call, now it's working again like before. Confirmed by user log and hardware.

@opdenkamp
Copy link
Contributor

I've done this change a bit differently so it only needs 1 match and doesn't check all active devices. Thanks!

@opdenkamp opdenkamp closed this in 5e5788d Mar 28, 2020
@Portisch
Copy link
Author

Portisch commented Mar 29, 2020

Sorry, but it looks like this isn't working as the audio device is not getting polled:
http://ix.io/2fRb

Here the log with my patch where it's working:
http://ix.io/2dDh

What I have seen this call is needed to make a poll on the CEC bus:
77509de#diff-2ceaa2986364201cfc2645aad3c5f817R1466

@Portisch
Copy link
Author

Portisch commented Apr 8, 2020

Fixed by d9c415c & 416e136!
Could confirm it's working now by a test user.
Thank you very much!

Portisch added a commit to CoreELEC/CoreELEC that referenced this pull request Apr 8, 2020
IsActiveDeviceType: poll only matching device type PR got merged at 
Pulse-Eight/libcec#492
spycat88 pushed a commit to CoreELEC/CoreELEC that referenced this pull request Apr 8, 2020
IsActiveDeviceType: poll only matching device type PR got merged at
Pulse-Eight/libcec#492
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants