fix: exit early when both atomics and ServiceWorker are not supported #237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
It doesn't appear the e2e tests are passing with this PR. Would you be able to further debug why the test isn't passing? Thanks |
|
Yeah, I saw that. I’ll try to find some time this week. |
slawekkolodziej
force-pushed
the
fix/exit-early-from-init-snippet
branch
from
f6abed6 to
03231fc
Compare
mhevery
approved these changes
Sep 6, 2023
|
Thank you for your contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug that prevents some 3rd party scripts from loading in browsers that does not support service workers and atomics.
Partytown initializes all of the properties listed in the 'forwarded' array. However, at this point, it does not check to see if the browser supports the required features; this is done later. As a result, some third-party scripts may mistakenly perceive themselves as already loaded (for example FB pixel checks if the
fbqproperty is present).In my experience, the most common browser that does not support Partytown is... the iOS in-app browser! Users who click on Facebook ads see your website without Partytown loaded.