Redesign Task Requestor Details Modals #951
Open
+171
−46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you please also add a screenshot of the mobile view in the screenshot section and the design doc link too |
RishiChaubey31
requested changes
Feb 24, 2025
MayankBansal12
suggested changes
Feb 24, 2025
There was a problem hiding this comment.
why use params.get('dev') == 'true' everywhere? check if a variable is already storing this otherwise make one and use that
Comment on lines
711
to
722
| } else { | ||
| descriptionValue.textContent = userData.description; | ||
| if (params.get('dev') == 'true') { | ||
| if (userData.description) { | ||
| descriptionValue.textContent = userData.description; | ||
| } else { | ||
| descriptionValue.textContent = 'N/A'; | ||
| descriptionValue.className = 'proposed-description-value'; | ||
| } | ||
| } else { | ||
| descriptionValue.textContent = userData.description; | ||
| } | ||
| } |
Added a mobile UI view also |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Date: 24 Feb 2024
Developer Name: Hariom Vashista
Issue Ticket Number
Fixes: Issue #803
Description
This PR aims at redesigning the task request details modal and adding it under feature flag.
Documentation Updated?
Under Feature Flag
Database Changes
Breaking Changes
Development Tested?
Screenshots
Screenshot 1
Before:
Desktop View:
Mobile View:
After:
Desktop View:
Mobile View:
Test Coverage
Screenshot 1
Task Request Test Coverage:
Task Request Details Test Coverage:
Additional Notes
The task is under feature flag and after it has been tested on prod for 10-15 days and everything is working fine. Then a new task/PR will be created to remove the feature flag