Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The editor MP calculation with the action combining system needs refactoring #5932

Open
hhyyrylainen opened this issue Feb 22, 2025 · 0 comments

Comments

@hhyyrylainen
Copy link
Member

as the system is way too complex to use correctly. I've just spent this week like at least 5 hours fighting the system, and this isn't the first feature that has such a problem.

I just think the whole system needs to be scrapped as it is way too hard to use. And I haven't seen the other programmers really to even try.

My idea is that we get rid of the minimum action combining logic and instead make it so that all action data itself is asked how much MP it costs given a history of actions. That way actions can inspect the history themselves and determine if they should give any discounts. This results in more manual code in each action type but gets rid of the really unexpected action combining system that I cannot seem to wrap my head around.

@hhyyrylainen hhyyrylainen added this to the Release 0.8.2 milestone Feb 22, 2025
@github-project-automation github-project-automation bot moved this to Backburner in Thrive Planning Feb 22, 2025
@hhyyrylainen hhyyrylainen moved this from Backburner to Features for next release in Thrive Planning Feb 22, 2025
hhyyrylainen added a commit that referenced this issue Feb 22, 2025
but had to break tolerance combining after another action has been done in between: #5932
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Features for next release
Development

No branches or pull requests

1 participant