Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type annotate the ndspy.bmg module #10

Merged
merged 9 commits into from
Sep 22, 2023
Merged

Type annotate the ndspy.bmg module #10

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
7d8bf2e
Add some type annotations to `bmg` module
mike8699 Sep 7, 2023
05c5c3b
Require >= Python 3.7
mike8699 Sep 7, 2023
996e8d4
Update README with new Python version requirement
mike8699 Sep 7, 2023
523b83e
Add type annotations for the rest of the `bmg` module
mike8699 Sep 11, 2023
50c1fea
Remove redudant `None` return type hints
mike8699 Sep 21, 2023
8406e7a
Declare instance vars w/ annotations in class body
mike8699 Sep 21, 2023
098dcdd
Fix `typing.Literal` not being supported on Python 3.7
mike8699 Sep 21, 2023
9fc4378
Make `encoding` a `Literal` type
mike8699 Sep 22, 2023
2403dbf
Fix type of `Message`.stringParts
mike8699 Sep 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion ndspy/bmg.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,10 @@

import os
import struct
from typing import Literal
from typing import TYPE_CHECKING

if TYPE_CHECKING:
from typing import Literal

from . import _common

Expand Down