Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔥Hotfix - Fix Corepack error in build pipeline #3571

Merged
merged 4 commits into from
Feb 3, 2025

Conversation

Calinator444
Copy link
Member

@Calinator444 Calinator444 commented Feb 3, 2025

Older versions of Corepack have the the npm registrey key (which was recently updated) hard coded. The alpine image we use in the Docker container for our deployment pipeline still uses a version of Corepack with the old key, causing our deployments to fail when we try to enable Corepack during the build step.

See issue nodejs/corepack#625 (comment).

To fix this I've updated our build pipeline to manually install the latest version of Corepack. The fix was published here.

image

Figure: Build pipeline running successfully

Copy link
Contributor

github-actions bot commented Feb 3, 2025

Coverage report

St.
Category Percentage Covered / Total
🔴 Statements 0.19% 69/36379
🔴 Branches 6.09% 24/394
🔴 Functions 0.8% 3/373
🔴 Lines 0.19% 69/36379

Test suite run success

13 tests passing in 1 suite.

Report generated by 🧪jest coverage report action from e0d21ff

@Calinator444 Calinator444 changed the title manually installing corepack inside of docker image 🔧BugFix - Fix corepack error in build pipeline Feb 3, 2025
Copy link
Contributor

github-actions bot commented Feb 3, 2025

Deployed changes to https://app-sswwebsite-9eb3-pr-3571.azurewebsites.net

Copy link
Contributor

github-actions bot commented Feb 3, 2025

PageSpeed Insights

Category Score
Accessibility 95
Best practices 96
Performance 75
SEO 69

View the full report https://pagespeed.web.dev/report?url=https://app-sswwebsite-9eb3-pr-3571.azurewebsites.net

@Calinator444 Calinator444 changed the title 🔧BugFix - Fix corepack error in build pipeline 🔥Hotfix - Fix Corepack error in build pipeline Feb 3, 2025
Copy link
Member

@wicksipedia wicksipedia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense if the docker tag now points to a version that doesn't include corepack

@Calinator444 Calinator444 merged commit bcef8f7 into main Feb 3, 2025
11 checks passed
@Calinator444 Calinator444 deleted the fix-docker-image-v2 branch February 3, 2025 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🚀 CI/CD - CorePack Build error in pipeline
2 participants