Add cache check when activating a product with SCC #1278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a BYOS or HYBRID system activates a product with SCC we check first if the registration code use for that activation is in the cache for that product If there is a match in the cache and the registration code is active we do not reach to SCC, update the cache and update the system pubcloud_reg_code if reg code is new or different If there is no match in the cache we call SCC, update the cache and update the system pubcloud_reg_code if it's new or different If the registration code is inactive, we do not follow with the activation
7 tasks
rjschwei
requested changes
Jan 27, 2025
engines/instance_verification/lib/instance_verification/engine.rb
Outdated
Show resolved
Hide resolved
engines/instance_verification/lib/instance_verification/engine.rb
Outdated
Show resolved
Hide resolved
engines/instance_verification/lib/instance_verification/engine.rb
Outdated
Show resolved
Hide resolved
Add new methods to handle the cache in the InstanceVerification engine Update some tests
The InstanceVerification engine is the engine responsible to handle the cache before We are editing the way we cache the information, so that engine gets more methods to do so All the places where we edit the cache should call these methods
… system with a previous reg code
jesusbv
force-pushed
the
cache-activate-product
branch
2 times, most recently
from
2734619 to
a7be943
Compare
jesusbv
force-pushed
the
cache-activate-product
branch
from
d4f0e7e to
d4a946e
Compare
jesusbv
force-pushed
the
cache-activate-product
branch
from
707a3b6 to
5cacbb9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When a BYOS or HYBRID system activates a product with SCC we check first if the registration code use for that activation is in the cache for that product
If there is a match in the cache and the registration code is active we do not reach to SCC, update the cache and update the system pubcloud_reg_code if reg code is new or different
If there is no match in the cache we call SCC, update the cache and update the system pubcloud_reg_code if it's new or different
If the registration code is inactive, we do not follow with the activation
How to test
Change Type
Please select the correct option.
Checklist
Please check off each item if the requirement is met.
MANUAL.mdfile with any changes to the user experience.package/obs/rmt-server.changes.Review
Please check out our review guidelines
and get in touch with the author to get a shared understanding of the change.