Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support programs built w/ ASan (#1114) #1116

Merged
merged 1 commit into from
Jun 4, 2023

Conversation

acidghost
Copy link
Contributor

Fixes #1114.

@codecov
Copy link

codecov bot commented Jun 3, 2023

Codecov Report

Merging #1116 (4cddd63) into master (a17dd5f) will decrease coverage by 0.01%.
The diff coverage is 77.77%.

❗ Current head 4cddd63 differs from pull request most recent head f4bc14e. Consider uploading reports for the commit f4bc14e to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1116      +/-   ##
==========================================
- Coverage   64.58%   64.57%   -0.01%     
==========================================
  Files         223      223              
  Lines       23552    23557       +5     
==========================================
+ Hits        15210    15213       +3     
- Misses       8342     8344       +2     
Impacted Files Coverage Δ
svf-llvm/include/SVF-LLVM/LLVMUtil.h 73.33% <ø> (ø)
svf-llvm/lib/LLVMUtil.cpp 68.88% <71.42%> (+0.04%) ⬆️
svf-llvm/lib/CHGBuilder.cpp 86.61% <100.00%> (-0.10%) ⬇️

@acidghost
Copy link
Contributor Author

I'm not entirely sure I've got all the locations where it needs to be replaced with getVtblStruct.

@yuleisui
Copy link
Collaborator

yuleisui commented Jun 4, 2023

I'm not entirely sure I've got all the locations where it needs to be replaced with getVtblStruct.

Looks to me like all have been replaced. Could you put a comment to explain the functiongetVtblStruct ?Maybe give a tiny llvm bc code fragment example with and without ASan. I will merge it after your comments.

@acidghost
Copy link
Contributor Author

It should be ready. Let me know if it needs any further update.

@yuleisui yuleisui merged commit a2f83d2 into SVF-tools:master Jun 4, 2023
@acidghost acidghost deleted the fix-1114 branch June 5, 2023 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for C++ virtual methods with AddressSanitizer
2 participants