Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issue 1139 #1155

Merged
Merged
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions svf/include/WPA/Andersen.h
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,10 @@ class AndersenBase: public WPAConstraintSolver, public BVDataPTAImpl
/// Andersen analysis
virtual void analyze() override;

virtual void analyzeAndWrite(const std::string& filename);

virtual void solveConstraints();

/// Initialize analysis
virtual void initialize() override;

Expand Down
14 changes: 14 additions & 0 deletions svf/include/WPA/FlowSensitive.h
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,16 @@ class FlowSensitive : public WPASVFGFSSolver, public BVDataPTAImpl
return fspta.get();
}

static FlowSensitive* createFSWPA(SVFIR* _pag, const std::string& filename)
{
if (fspta == nullptr)
{
fspta = std::unique_ptr<FlowSensitive>(new FlowSensitive(_pag));
fspta->analyzeAndWrite(filename);
}
return fspta.get();
}

/// Release flow-sensitive pointer analysis
static void releaseFSWPA()
{
Expand All @@ -101,6 +111,10 @@ class FlowSensitive : public WPASVFGFSSolver, public BVDataPTAImpl
/// Flow sensitive analysis
void analyze() override;

virtual void analyzeAndWrite(const std::string& filename);

virtual void solveConstraints();

/// Initialize analysis
void initialize() override;

Expand Down
4 changes: 2 additions & 2 deletions svf/lib/MemoryModel/PointerAnalysisImpl.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -169,7 +169,7 @@ void BVDataPTAImpl::writeObjVarToFile(const string& filename)
outs() << " error opening file for writing!\n";
return;
}

// Write BaseNodes insensitivity to file
NodeBS NodeIDs;
for (auto it = pag->begin(), ie = pag->end(); it != ie; ++it)
Expand All @@ -185,14 +185,14 @@ void BVDataPTAImpl::writeObjVarToFile(const string& filename)

f << "------\n";

// Job finish and close file
f.close();
if (f.good())
{
outs() << "\n";
return;
}


}

/*!
Expand Down
68 changes: 47 additions & 21 deletions svf/lib/WPA/Andersen.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -97,28 +97,9 @@ void AndersenBase::finalize()
BVDataPTAImpl::finalize();
}

/*!
* Andersen analysis
*/
void AndersenBase::analyze()
void AndersenBase::solveConstraints()
{
/// Initialization for the Solver
initialize();

bool readResultsFromFile = false;
if(!Options::ReadAnder().empty())
{
readResultsFromFile = this->readFromFile(Options::ReadAnder());
// Finalize the analysis
PointerAnalysis::finalize();
}

if (!Options::WriteAnder().empty())
this->writeObjVarToFile(Options::WriteAnder());

if(!readResultsFromFile)
{
// Start solving constraints
// Start solving constraints
DBOUT(DGENERAL, outs() << SVFUtil::pasMsg("Start Solving Constraints\n"));

bool limitTimerSet = SVFUtil::startAnalysisLimitTimer(Options::AnderTimeLimit());
Expand All @@ -144,9 +125,30 @@ void AndersenBase::analyze()
SVFUtil::stopAnalysisLimitTimer(limitTimerSet);

DBOUT(DGENERAL, outs() << SVFUtil::pasMsg("Finish Solving Constraints\n"));
}

/*!
* Andersen analysis
*/
void AndersenBase::analyze()
{
/// Initialization for the Solver
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if(!Options::ReadAnder().empty()){
readPtsFromFile(Options::ReadAnder());
}
else{
if(Options::WriteAnder().empty()) {
initialize();
solveConstraints();
finalize();
}
else{
solveAndwritePtsToFile(Options::WriteAnder());
}
}

readPtsFromFile(filename){

initialize();
this->readFromFile(Options::ReadAnder());
PointerAnalysis::finalize();
}

initialize();

bool readResultsFromFile = false;
if(!Options::ReadAnder().empty())
{
readResultsFromFile = this->readFromFile(Options::ReadAnder());
// Finalize the analysis
PointerAnalysis::finalize();
}

if (!Options::WriteAnder().empty())
this->writeObjVarToFile(Options::WriteAnder());

if(!readResultsFromFile)
solveConstraints();

if (!Options::WriteAnder().empty())
{
this->writeToFile(Options::WriteAnder());
Expand All @@ -157,6 +159,30 @@ void AndersenBase::analyze()
finalize();
}


void AndersenBase::analyzeAndWrite(const std::string& filename)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

analyzeAndWrite => SolveAndWritePtsToFile

SolveAndWritePtsToFile(filename){

initialize();
this->writeObjVarToFile(filename);
solveConstraints();
this->writeToFile(filename);
finalize();

}

{
/// Initialization for the Solver
initialize();

bool readResultsFromFile = false;

if (filename.empty())
this->writeObjVarToFile(filename);

if(!readResultsFromFile)
solveConstraints();

if (filename.empty())
{
this->writeToFile(filename);
}

if (!readResultsFromFile)
// Finalize the analysis
finalize();
}

void AndersenBase::cleanConsCG(NodeID id)
{
consCG->resetSubs(consCG->getRep(id));
Expand Down
52 changes: 41 additions & 11 deletions svf/lib/WPA/FlowSensitive.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -74,18 +74,8 @@ void FlowSensitive::initialize()
setGraph(svfg);
//AndersenWaveDiff::releaseAndersenWaveDiff();
}

/*!
* Start analysis
*/
void FlowSensitive::analyze()
void FlowSensitive::solveConstraints()
{
bool limitTimerSet = SVFUtil::startAnalysisLimitTimer(Options::FsTimeLimit());

/// Initialization for the Solver
initialize();

double start = stat->getClk(true);
/// Start solving constraints
DBOUT(DGENERAL, outs() << SVFUtil::pasMsg("Start Solving Constraints\n"));

Expand All @@ -104,6 +94,46 @@ void FlowSensitive::analyze()
while (updateCallGraph(getIndirectCallsites()));

DBOUT(DGENERAL, outs() << SVFUtil::pasMsg("Finish Solving Constraints\n"));
}

/*!
* Start analysis
*/
void FlowSensitive::analyzeAndWrite(const std::string& filename)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add two methods "solveAndwritePtsToFile" and "readPtsFromFile"

{
bool limitTimerSet = SVFUtil::startAnalysisLimitTimer(Options::FsTimeLimit());

/// Initialization for the Solver
initialize();

double start = stat->getClk(true);
writeObjVarToFile(filename);
solveConstraints();

// Reset the time-up alarm; analysis is done.
SVFUtil::stopAnalysisLimitTimer(limitTimerSet);

writeToFile(filename);

double end = stat->getClk(true);
solveTime += (end - start) / TIMEINTERVAL;

/// finalize the analysis
finalize();
}

/*!
* Start analysis
*/
void FlowSensitive::analyze()
{
bool limitTimerSet = SVFUtil::startAnalysisLimitTimer(Options::FsTimeLimit());

/// Initialization for the Solver
initialize();

double start = stat->getClk(true);
solveConstraints();

// Reset the time-up alarm; analysis is done.
SVFUtil::stopAnalysisLimitTimer(limitTimerSet);
Expand Down