fix getgepoffset and accumulateconstantOffset #1184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
support byte size
yuleisui
reviewed
Sep 5, 2023
| @@ -201,74 +201,110 @@ std::pair<s32_t, s32_t> SVFIR2ItvExeState::getGepOffset(const GepStmt *gep) | |||
| else | |||
| { | |||
| u32_t idx = _svfir->getValueNode(value); | |||
| if (!inVarToIValTable(idx)) return std::make_pair(-1, -1); | |||
| //if (!inVarToIValTable(idx)) return std::make_pair(-1, -1); | |||
There was a problem hiding this comment.
remove this commented line.
yuleisui
reviewed
Sep 5, 2023
svf/include/MemoryModel/AccessPath.h
Outdated
| @@ -110,7 +110,7 @@ class AccessPath | |||
| //@} | |||
|
|
|||
| /// Return accumulated constant offset given OffsetVarVec | |||
| APOffset computeConstantOffset() const; | |||
| APOffset computeConstantOffset(u32_t elem_bytesize, bool getByteOffset) const; | |||
There was a problem hiding this comment.
can we make it default parameters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1184 +/- ##
==========================================
- Coverage 64.74% 64.64% -0.11%
==========================================
Files 222 222
Lines 23483 23525 +42
==========================================
+ Hits 15204 15207 +3
- Misses 8279 8318 +39
|
added 2 commits
September 6, 2023 07:52
1. add getBytefromGepTypePair in SvfIR2ItvExeState 2. add getIndexfromGepTypePair in SvfIR2ItvExeState 3. add accumulateConstantByteOffset in AccessPath
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
support byte size