Suppress warnings for unused variables when SVF_ENABLE_ASSERTIONS is … #1238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…not defined. When SVF_ENABLE_ASSERTIONS is not defined when running cmake, assert in two .h files will be removed, causing unused variable warning. It then leads to compilation errors due to "-Werror -Wunused-variable". Fixing it by replacing variables in assert with the target expressions. For two functions that cannot be fixed in this way, i.e., CFBasicBlockG.h/add CFBBEdge() and CDG.h/addCDGEDge(), put the two variables in the return statements.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1238 +/- ##
==========================================
- Coverage 64.50% 64.49% -0.01%
==========================================
Files 223 223
Lines 23667 23669 +2
==========================================
Hits 15266 15266
- Misses 8401 8403 +2 |
|
Thanks for the fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…not defined.
When SVF_ENABLE_ASSERTIONS is not defined when running cmake, assert in two .h files will be removed, causing unused variable warning. It then leads to compilation errors due to "-Werror -Wunused-variable".
Fixing it by replacing variables in assert with the target expressions. For two functions that cannot be fixed in this way, i.e., CFBasicBlockG.h/add CFBBEdge() and CDG.h/addCDGEDge(), put the two variables in the return statements.