opaque pointer support (type inference) for c #1323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #1323 +/- ##
==========================================
+ Coverage 65.72% 65.96% +0.23%
==========================================
Files 225 227 +2
Lines 24255 24452 +197
==========================================
+ Hits 15942 16130 +188
- Misses 8313 8322 +9
|
yuleisui
reviewed
Jan 16, 2024
svf-llvm/include/SVF-LLVM/LLVMUtil.h
Outdated
|
|
||
|
|
||
| /// Select the largest (conservative) type from all types | ||
| const Type* selectLargestType(std::vector<const Type*>& objTys); |
yuleisui
reviewed
Jan 16, 2024
svf-llvm/include/SVF-LLVM/LLVMUtil.h
Outdated
| /// Select the largest (conservative) type from all types | ||
| const Type* selectLargestType(std::vector<const Type*>& objTys); | ||
|
|
||
| u32_t getArgNoInCallBase(const CallBase* callBase, const Value* arg); |
svf-llvm/include/SVF-LLVM/LLVMUtil.h
Outdated
| @@ -446,9 +455,7 @@ const Value* getVCallVtblPtr(const CallBase* cs); | |||
| s32_t getVCallIdx(const CallBase* cs); | |||
There was a problem hiding this comment.
consider moving cpp related methods to cpputil
svf-llvm/include/SVF-LLVM/LLVMUtil.h
Outdated
| @@ -446,9 +455,7 @@ const Value* getVCallVtblPtr(const CallBase* cs); | |||
| s32_t getVCallIdx(const CallBase* cs); | |||
| bool classTyHasVTable(const StructType* ty); | |||
| std::string getClassNameFromType(const StructType* ty); | |||
| std::string getClassNameOfThisPtr(const CallBase* cs); | |||
| @@ -82,6 +84,18 @@ class SymbolTableBuilder | |||
| void handleCE(const Value* val); | |||
| // @} | |||
|
|
|||
|
|
|||
| std::unique_ptr<TypeInference> & getTypeInference(); | |||
| std::unique_ptr<TypeInference> & getTypeInference(); | ||
|
|
||
| /// Forward collect all possible infer sites starting from a value | ||
| const Type* getOrInferLLVMObjType(const Value *startValue); |
| } | ||
|
|
||
| /// get or infer the type of a value | ||
| const Type *getOrInferLLVMObjType(const Value *startValue); |
| private: | ||
|
|
||
| /// Forward collect all possible infer sites starting from a value | ||
| const Type *fwGetOrInferLLVMObjType(const Value *startValue); |
| const Type *fwGetOrInferLLVMObjType(const Value *startValue); | ||
|
|
||
| /// Backward collect all possible allocation sites (stack, static, heap) starting from a value | ||
| Set<const Value *> bwGetOrfindAllocations(const Value *startValue); |
svf-llvm/lib/SymbolTableBuilder.cpp
Outdated
| @@ -599,7 +650,7 @@ ObjTypeInfo* SymbolTableBuilder::createObjTypeInfo(const Value* val) | |||
| } | |||
| else | |||
| { | |||
| SVFUtil::errs() << dumpValue(val) << "\n"; | |||
| SVFUtil::errs() << VALUE_WITH_DBGINFO(val) << "\n"; | |||
There was a problem hiding this comment.
make it a function dumpValueAndDbgInfo
svf/lib/Graphs/CHG.cpp
Outdated
| @@ -75,6 +75,8 @@ void CHGraph::addEdge(const string className, const string baseClassName, | |||
| { | |||
| CHNode *srcNode = getNode(className); | |||
| CHNode *dstNode = getNode(baseClassName); | |||
| // cannot self inheritance | |||
| if(srcNode == dstNode && edgeType == CHEdge::INHERITANCE) return; | |||
There was a problem hiding this comment.
put it in separate cpp patch
jumormt
force-pushed
the
opaque-c
branch
2 times, most recently
from
76e7260 to
6a31b42
Compare
yuleisui
reviewed
Jan 21, 2024
| Set<const Value *> bwfindAllocations(const Value *startValue); | ||
|
|
||
| /// Determine type based on infer site | ||
| static const Type *infersiteToType(const Value *val); |
| /// Determine type based on infer site | ||
| static const Type *infersiteToType(const Value *val); | ||
|
|
||
| static bool isAllocation(const Value *val); |
| static const Type *defaultTy(const Value *val); | ||
|
|
||
| /// Opaque pointer type | ||
| inline static const Type *defaultPtrTy() { |
| return PointerType::getUnqual(getLLVMCtx()); | ||
| } | ||
|
|
||
| inline static LLVMContext &getLLVMCtx() { |
| void typeSizeDiffTest(const PointerType *oPTy, const Type *iTy, const Value *val); | ||
|
|
||
| /// Default type | ||
| static const Type *defaultTy(const Value *val); |
|
|
||
| public: | ||
|
|
||
| explicit TypeInference() = default; |
There was a problem hiding this comment.
TypeInference(LLVMContext &)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.