Bump LLVM to Version 16 #1357
Merged
Bump LLVM to Version 16 #1357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #1357 +/- ##
==========================================
- Coverage 66.27% 66.13% -0.15%
==========================================
Files 227 227
Lines 24653 24648 -5
==========================================
- Hits 16340 16302 -38
- Misses 8313 8346 +33
|
yuleisui
reviewed
Feb 4, 2024
| if [ $? -eq 0 ]; then | ||
| echo "Homebrew installation completed." | ||
| else | ||
| echo "Homebrew installation failed." |
yuleisui
reviewed
Feb 4, 2024
build.sh
Outdated
| build_llvm_from_source | ||
| if [[ "$sysOS" = "Darwin" ]]; then | ||
| echo "Installing LLVM binary for $OSDisplayName" | ||
| brew install llvm@16 |
There was a problem hiding this comment.
try to use macro rather than llvm@16
yuleisui
reviewed
Feb 4, 2024
build.sh
Outdated
| echo "LLVM binary installation failed." | ||
| exit 1 | ||
| fi | ||
| export LLVM_DIR="$(brew --prefix llvm@16)" |
There was a problem hiding this comment.
replace llvm@16 with a macro
yuleisui
reviewed
Feb 4, 2024
| @@ -15,18 +15,16 @@ SCRIPT_DIR=$( cd -- "$( dirname -- "${BASH_SOURCE[0]}" )" &> /dev/null && pwd ) | |||
| SVFHOME="${SCRIPT_DIR}" | |||
| sysOS=$(uname -s) | |||
| arch=$(uname -m) | |||
There was a problem hiding this comment.
majorLLVMVer=16
LLVMVer=$(majorLLVMVer).0.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.