fix some non-ret and unused var warning

svf-llvm/lib/LLVMUtil.cpp

@@ -363,8 +363,7 @@ void LLVMUtil::getPrevInsts(const Instruction* curInst, std::vector<const SVFIns
  */
 const Value* LLVMUtil::getFirstUseViaCastInst(const Value* val)
 {
-    const PointerType * type = SVFUtil::dyn_cast<PointerType>(val->getType());
-    assert(type && "this value should be a pointer type!");
+    assert(SVFUtil::isa<PointerType>(val->getType()) && "this value should be a pointer type!");
     /// If type is void* (i8*) and val is immediately used at a bitcast instruction
     const Value *latestUse = nullptr;
     for (const auto &it : val->uses())

svf-llvm/lib/SVFIRBuilder.cpp

@@ -290,7 +290,7 @@ bool SVFIRBuilder::computeGepOffset(const User *V, AccessPath& ap)
 
         assert((prevPtrOperand && svfGepTy->isPointerTy()) == false &&
                "Expect no more than one gep operand to be of a pointer type");
-        if(svfGepTy->isPointerTy()) prevPtrOperand = true;
+        if(!prevPtrOperand && svfGepTy->isPointerTy()) prevPtrOperand = true;
         const Value* offsetVal = gi.getOperand();
         const SVFValue* offsetSvfVal = LLVMModuleSet::getLLVMModuleSet()->getSVFValue(offsetVal);
         assert(gepTy != offsetVal->getType() && "iteration and operand have the same type?");

svf-llvm/tools/AE/ae.cpp

@@ -631,11 +631,10 @@ int main(int argc, char** argv)
         arg_value[arg_num] = argv[arg_num];
     }
     // add extra options
-    int orgArgNum = arg_num;
     arg_value[arg_num++] = (char*) "-model-consts=true";
     arg_value[arg_num++] = (char*) "-model-arrays=true";
     arg_value[arg_num++] = (char*) "-pre-field-sensitive=false";
-    assert(arg_num == (orgArgNum + extraArgc) && "more extra arguments? Change the value of extraArgc");
+    assert(arg_num == (argc + extraArgc) && "more extra arguments? Change the value of extraArgc");
 
     std::vector<std::string> moduleNameVec;
     moduleNameVec = OptionBase::parseOptions(

svf/include/Graphs/WTO.h

@@ -36,6 +36,7 @@
 
 #include "SVFIR/SVFType.h"
 #include "SVFIR/SVFValue.h"
+#include <functional>
 
 namespace SVF
 {

svf/lib/AE/Svfexe/AbstractExecution.cpp

@@ -1383,6 +1383,7 @@ u32_t AEAPI::getAllocaInstByteSize(const AddrStmt *addr)
         }
     }
     assert (false && "Addr rhs value is not ObjVar");
+    abort();
 }
 
 IntervalValue AEAPI::traceMemoryAllocationSize(const SVFValue *value)

svf/lib/AE/Svfexe/BufOverflowChecker.cpp

@@ -414,6 +414,7 @@ bool BufOverflowCheckerAPI::detectStrcat(const CallICFGNode *call)
     else
     {
         assert(false && "unknown strcat function, please add it to strcatGroup or strncatGroup");
+        abort();
     }
 }
 

svf/lib/AE/Svfexe/ICFGSimplification.cpp

@@ -126,8 +126,7 @@ void ICFGSimplification::mergeAdjacentNodes(ICFG* icfg)
             // merge the following nodes, until the next subnode
             while (subNodes.find(next) == subNodes.end())
             {
-                ICFGNode* rep_next = const_cast<ICFGNode*>(icfg->getRepNode(next));
-                assert(rep_next != head && "should not find a circle here");
+                assert(icfg->getRepNode(next) != head && "should not find a circle here");
                 icfg->removeICFGEdge(*head->getOutEdges().begin());
                 std::vector<ICFGEdge*> rm_edges;
                 // Step 1: merge the out edges of next to head

svf/lib/AE/Svfexe/SVFIR2ItvExeState.cpp

@@ -105,6 +105,7 @@ IntervalValue SVFIR2ItvExeState::getRangeLimitFromType(const SVFType* type)
     else
     {
         assert(false && "cannot support");
+        abort();
     }
 }
 

svf/lib/MemoryModel/AccessPath.cpp

@@ -165,17 +165,16 @@
 {
     const SVFValue* idxValue = idxOperandVar->getValue();
     u32_t structByteOffset = 0;
-    if (const SVFConstantInt *op = SVFUtil::dyn_cast<SVFConstantInt>(idxValue))
-    {
-        for (u32_t structField = 0; structField < (u32_t)op->getSExtValue(); ++structField)
-        {
+    if (const SVFConstantInt *op = SVFUtil::dyn_cast<SVFConstantInt>(idxValue)) {
+        for (u32_t structField = 0; structField < (u32_t) op->getSExtValue(); ++structField) {
             u32_t flattenIdx = idxOperandType->getTypeInfo()->getFlattenedFieldIdxVec()[structField];
             structByteOffset += idxOperandType->getTypeInfo()->getOriginalElemType(flattenIdx)->getByteSize();
         }
         return structByteOffset;
-    }
-    else
+    } else {
         assert(false && "struct type can only pair with constant idx");
+        abort();
+    }
 }
 
 /// Return accumulated constant offset