Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Text: improve support for null strings #3892

Merged
merged 4 commits into from
Jun 5, 2024

Conversation

sdpenner
Copy link
Contributor

@sdpenner sdpenner commented Jun 2, 2024

Added null check for Text plottable. Sets the text to String.Empty if null. Added unit test.

Not sure this is the best location for this test or should be in another unit test class...closes #3861

sdpenner and others added 3 commits June 2, 2024 08:41
@swharden
Copy link
Member

swharden commented Jun 5, 2024

Thanks @sdpenner, this looks great! 🚀

@swharden swharden enabled auto-merge (squash) June 5, 2024 12:16
@swharden swharden changed the title Added null check for Text plottable. Closes #3861 Text: improve support for null strings Jun 5, 2024
@swharden swharden merged commit a7510d7 into ScottPlot:main Jun 5, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crash when Label text is null
2 participants