Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Coxcomb: fix position of intiial slice to match rotation setting (#4304) #4305

Merged
merged 4 commits into from
Oct 10, 2024
Merged

Coxcomb: fix position of intiial slice to match rotation setting (#4304) #4305

merged 4 commits into from
Oct 10, 2024

Conversation

johndoh
Copy link
Contributor

@johndoh johndoh commented Oct 7, 2024

fix for the initial double rotation issue described in #4304

@swharden
Copy link
Member

Thanks @johndoh, this looks great!

I refactored it a bit to overcome merge conflicts caused by #4278 and #4280 but it's looking good now and will be in the next release 👍

@swharden swharden merged commit 796b2dd into ScottPlot:main Oct 10, 2024
3 checks passed
@johndoh johndoh deleted the johndoh-coxcomb branch October 21, 2024 07:27
@swharden swharden mentioned this pull request Nov 8, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@johndoh @swharden