Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support PgVector #2500

Merged
merged 15 commits into from
Feb 18, 2025
Merged

Support PgVector #2500

merged 15 commits into from
Feb 18, 2025

Conversation

billy1624
Copy link
Member

@billy1624 billy1624 commented Feb 18, 2025 •
edited
Loading

@billy1624 billy1624 self-assigned this Feb 18, 2025
@billy1624 billy1624 marked this pull request as ready for review February 18, 2025 10:03
@billy1624 billy1624 requested a review from tyt2y3 February 18, 2025 10:03
tyt2y3
tyt2y3 reviewed Feb 18, 2025
View reviewed changes
tyt2y3
tyt2y3 reviewed Feb 18, 2025
View reviewed changes
tyt2y3
tyt2y3 reviewed Feb 18, 2025
View reviewed changes
.github/workflows/rust.yml
image: postgres:${{ matrix.version }}
image: pgvector/pgvector:pg${{ matrix.version }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does that mean we can't use the official image?

tyt2y3
tyt2y3 reviewed Feb 18, 2025
View reviewed changes
tyt2y3
tyt2y3 reviewed Feb 18, 2025
View reviewed changes
src/executor/query.rs
Comment on lines +957 to +958
#[cfg(feature = "postgres-vector")]
impl TryGetable for pgvector::Vector {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why are we nesting this under postgres-array?

@tyt2y3 tyt2y3 merged commit ce69458 into master Feb 18, 2025
36 checks passed
@tyt2y3 tyt2y3 deleted the pg-vector branch February 18, 2025 22:36
@28Smiles
Copy link
Contributor

Thank you, i did not have time to update my fork :)

@tyt2y3
Copy link
Member

tyt2y3 commented Feb 21, 2025

@28Smiles you've helped a lot already. I will release it this weekend :)

@github-actions GitHub Actions
Copy link

🎉 Released In 1.1.6 🎉

Thank you everyone for the contribution!
This feature is now available in the latest release. Now is a good time to upgrade!
Your participation is what makes us unique; your adoption is what drives us forward.
You can support SeaQL 🌊 by starring our repos, sharing our libraries and becoming a sponsor ⭐.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tyt2y3 tyt2y3 tyt2y3 approved these changes

Assignees

@billy1624 billy1624

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@billy1624 @28Smiles @tyt2y3