-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(jest): setup jest for frontend #331
Conversation
Hi @Bhavin789 |
Sure @palash-signoz , whenever you are available 🙂. |
Hi @Bhavin789 Please go through the suggestion which will help to review your PR
|
Hi @Bhavin789 please update the threads also |
@pal-sig Have updated the threads and resolved all except for the removal of |
no please don't remove that one |
@pal-sig Adding it back is actually throwing error on expect. Is this change breaking anything? As per my limited knowledge, Any idea on how can I check if anything is breaking? If this is breaking anything, we can can by one redundant but easy route to explicitly include Let me know whichever way sounds good to you. Thanks! |
Hi @Bhavin789 I forget that cypress |
Awesome, thanks a ton for verification @pal-sig 🙌 Any reason why commit-lint is failing? Is there a way to re-trigger? Unable to understand the reason here. |
Hi @Bhavin789 I forget that cypress
You can check the logs |
Basically in the future will integrate husky with commit lint in the future which will reduce this type of error |
I actually did but could not find any specific reason. The PR title contains the format defined by commitlint itself with a valid type and subject but still its failing. Can you help identify the issue? I might be missing something here. |
yeah it is checking on the previous commit too |
Oh, this shouldn't be the case, right? As per what I have seen, we squash commits, and thus, we don't need to lint on the commit history messages. Please correct me if I am wrong here. In this case, is there any workaround to make the CI pass? @pal-sig |
Description
The PR sets up jest tests in the repo with support of custom matchers from React Testing library.
Closes #312
How to Test?
cd ./frontend
yarn test
NotFound
page.yarn test:coverage
NotFound
page along with coverage report which this test was able to capture.