Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update webpack config to typescript #334

Merged
merged 8 commits into from
Oct 27, 2021
Merged

Update webpack config to typescript #334

merged 8 commits into from
Oct 27, 2021

Conversation

lyqht
Copy link
Contributor

@lyqht lyqht commented Oct 7, 2021 •
edited
Loading

Addresses #320

@pranay01 pranay01 requested a review from palashgdev October 7, 2021 09:08
@palashgdev palashgdev assigned palashgdev and lyqht and unassigned palashgdev Oct 7, 2021
palashgdev
palashgdev suggested changes Oct 7, 2021
View reviewed changes
@lyqht
Copy link
Contributor Author

lyqht commented Oct 12, 2021

@pal-sig done the final changes that you have requested!

palashgdev
palashgdev suggested changes Oct 13, 2021
View reviewed changes
@palashgdev
Copy link
Contributor

Also, I see a warning can we also handle this one?

this is one when we are using dev script

Screenshot 2021-10-13 at 11 05 47 PM

@lyqht
Copy link
Contributor Author

lyqht commented Oct 14, 2021

Also, I see a warning can we also handle this one?

this is one when we are using dev script

Screenshot 2021-10-13 at 11 05 47 PM

have looked around - no solutions found and I'm not sure what is the cause for it. I don't think i can fix this.

@lyqht lyqht requested a review from palashgdev October 15, 2021 14:42
@palashgdev
Copy link
Contributor

Also, I see a warning can we also handle this one?
this is one when we are using dev script
Screenshot 2021-10-13 at 11 05 47 PM

have looked around - no solutions found and I'm not sure what is the cause for it. I don't think i can fix this.

Let me back get back to you over this one :-D

@lyqht
Copy link
Contributor Author

lyqht commented Oct 26, 2021

any update on this?

@palashgdev
Copy link
Contributor

Hi @lyqht
Can you please resolve the conflicts ?

@lyqht
Copy link
Contributor Author

lyqht commented Oct 27, 2021

@pal-sig done :)

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@ankitnayan ankitnayan merged commit 53d5225 into SigNoz:main Oct 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@palashgdev palashgdev palashgdev approved these changes

Assignees

@lyqht lyqht

Labels
frontend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lyqht @palashgdev @ankitnayan