Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(FE):Cypress global time test case #348

Merged
merged 8 commits into from
Oct 22, 2021
Merged

test(FE):Cypress global time test case #348

merged 8 commits into from
Oct 22, 2021

Conversation

palashgdev
Copy link
Contributor

In this PR

  1. global time test cases are included
  2. Login test case is updated

@palashgdev palashgdev added frontend test adding missing tests, refactoring tests; no production code change labels Oct 21, 2021
@palashgdev palashgdev requested a review from ankitnayan October 21, 2021 10:53
@palashgdev palashgdev self-assigned this Oct 21, 2021
@pranay01
Copy link
Collaborator

@pal-sig Can we keep test cases PRs to be modular? For example we can have 1 PR with test cases for global time module and another PR for login module. Will keep things easy to merge :) Just a note for the future PRs

@palashgdev
Copy link
Contributor Author

@pal-sig Can we keep test cases PRs to be modular? For example we can have 1 PR with test cases for global time module and another PR for login module. Will keep things easy to merge :) Just a note for the future PRs

Both test case's were dependent on each other...

Sure noted the point for further PR

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 7 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@ankitnayan ankitnayan merged commit ae4f75e into SigNoz:main Oct 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ankitnayan ankitnayan ankitnayan approved these changes

Assignees

@palashgdev palashgdev

Labels
frontend test adding missing tests, refactoring tests; no production code change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@palashgdev @pranay01 @ankitnayan