-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add k8s metrics receiving status #6977
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me! Reviewed everything up to cb6db04 in 1 minute and 36 seconds
More details
- Looked at
388
lines of code in6
files - Skipped
0
files when reviewing. - Skipped posting
5
drafted comments based on config settings.
1. pkg/query-service/app/inframetrics/nodes.go:72
- Draft comment:
Consider using a constant or configuration for the metric table name instead of hardcoding it. This will make future changes easier and reduce the risk of errors. - Reason this comment was not posted:
Confidence changes required:50%
The code uses a hardcoded metric table name for querying metrics. This can lead to issues if the table name changes in the future. It's better to use a constant or configuration for such values.
2. pkg/query-service/app/inframetrics/pods.go:115
- Draft comment:
Consider using a constant or configuration for the metric table name instead of hardcoding it. This will make future changes easier and reduce the risk of errors. - Reason this comment was not posted:
Confidence changes required:50%
The code uses a hardcoded metric table name for querying metrics. This can lead to issues if the table name changes in the future. It's better to use a constant or configuration for such values.
3. pkg/query-service/app/inframetrics/pods.go:129
- Draft comment:
Consider using a constant or configuration for the metric table name instead of hardcoding it. This will make future changes easier and reduce the risk of errors. - Reason this comment was not posted:
Confidence changes required:50%
The code uses a hardcoded metric table name for querying metrics. This can lead to issues if the table name changes in the future. It's better to use a constant or configuration for such values.
4. pkg/query-service/app/inframetrics/pods.go:143
- Draft comment:
Consider using a constant or configuration for the metric table name instead of hardcoding it. This will make future changes easier and reduce the risk of errors. - Reason this comment was not posted:
Confidence changes required:50%
The code uses a hardcoded metric table name for querying metrics. This can lead to issues if the table name changes in the future. It's better to use a constant or configuration for such values.
5. pkg/query-service/app/inframetrics/common.go:13
- Draft comment:
Avoid hardcoding color values. Use design tokens or predefined color constants instead. This applies to other hardcoded color values in this file as well. - Reason this comment was not posted:
Comment was not on a valid diff hunk.
Workflow ID: wflow_qNfU2Uwr0mK1qd4F
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
amlannandy
approved these changes
Jan 31, 2025
SagarRajput-7
pushed a commit
that referenced
this pull request
Feb 10, 2025
hudsongeovane
pushed a commit
to hudsongeovane/signoz
that referenced
this pull request
Feb 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This change adds the following information for handling empty data screens
Corresponding docs PR SigNoz/signoz-web#1141
Part of #6890
Important
Add API endpoint to check Kubernetes metrics onboarding status, with supporting functions and models.
/api/v1/infra_onboarding/k8s/status
endpoint inhttp_handler.go
to get Kubernetes metrics onboarding status.DidSendPodMetrics()
,DidSendClusterMetrics()
,IsSendingOptionalPodMetrics()
, andSendingRequiredMetadata()
toPodsRepo
inpods.go
.DidSendNodeMetrics()
toNodesRepo
innodes.go
.common.go
.OnboardingStatus
andPodOnboardingStatus
structs ininfra.go
to represent onboarding status.This description was created by
for cb6db04. It will automatically update as commits are pushed.