task(licenses): update the license events and the state names

[vikrantgupta25]

• changes for query service and frontend to adapt based on new license state

[request-info]

We would appreciate it if you could provide us with more info about this issue/pr!

[ellipsis-dev]

❌ Changes requested. Reviewed everything up to 53d8372 in 1 minute and 17 seconds

More details

• Looked at 86 lines of code in 6 files
• Skipped 0 files when reviewing.
• Skipped posting 11 drafted comments based on config settings.

1. ee/query-service/model/plans.go:24

• Draft comment:
  Rename of LicenseStatusInactive to LicenseStatusInvalid is consistent; ensure all related documentation and tests are updated.
• Reason this comment was not posted:
  Marked as duplicate.

2. frontend/src/AppRoutes/Private.tsx:159

• Draft comment:
  Verified update of LICENSE state check to DEFAULTED; ensure tests reflect new license state naming.
• Reason this comment was not posted:
  Decided after close inspection that this draft comment was likely wrong and/or not actionable: usefulness confidence = 10% vs. threshold = 50%
  The comment starts with "Verified" and contains "ensure", which are red flags according to our rules. It's asking the author to check tests, which falls under the category of asking authors to verify/ensure things. The comment isn't pointing out a specific issue that needs fixing.
  The change in license state could potentially break tests if they're not updated. This might be a legitimate concern.
  While test updates might be needed, this would be caught by the build/test pipeline if there were issues. Our rules specifically say not to make comments asking authors to verify or ensure things.
  The comment should be deleted as it violates our rule against asking authors to verify/ensure things, and any test failures would be caught by the build process.

3. frontend/src/container/AppLayout/index.tsx:425

• Draft comment:
  Avoid inline styling; consider moving dynamic styles into a styled component or CSS class.
• Reason this comment was not posted:
  Comment was not on a location in the diff, so it can't be submitted as a review comment.

4. frontend/src/pages/WorkspaceSuspended/WorkspaceSuspended.tsx:62

• Draft comment:
  License state check updated to DEFAULTED is correct; ensure consistency across UI flows.
• Reason this comment was not posted:
  Marked as duplicate.

5. frontend/src/types/api/licensesV3/getActive.ts:2

• Draft comment:
  LicenseEvent and LicenseState enums updated; verify any dependent logic uses new names.
• Reason this comment was not posted:
  Marked as duplicate.

6. ee/query-service/model/license.go:142

• Draft comment:
  Changed the status check from LicenseStatusInactive to LicenseStatusInvalid to default to the Basic plan. Ensure that all license workflows and tests are updated to reflect this new status name.
• Reason this comment was not posted:
  Marked as duplicate.

7. ee/query-service/model/plans.go:24

• Draft comment:
  Renamed the license status constant from 'INACTIVE' to 'INVALID'. Verify that all references to the 'inactive' status are updated consistently.
• Reason this comment was not posted:
  Marked as duplicate.

8. frontend/src/AppRoutes/Private.tsx:159

• Draft comment:
  Updated the license state check from PAYMENT_FAILED to DEFAULTED. Confirm that DEFAULTED is now the correct state for triggering workspace suspension.
• Reason this comment was not posted:
  Marked as duplicate.

9. frontend/src/container/AppLayout/index.tsx:253

• Draft comment:
  Updated the license event check from FAILED_PAYMENT to DEFAULT. Ensure that the backend now returns 'DEFAULT' for this event and that downstream logic uses the new enum correctly.
• Reason this comment was not posted:
  Marked as duplicate.

10. frontend/src/pages/WorkspaceSuspended/WorkspaceSuspended.tsx:63

• Draft comment:
  Modified the license state check from PAYMENT_FAILED to DEFAULTED. This change should ensure that the correct suspension condition is applied.
• Reason this comment was not posted:
  Marked as duplicate.

11. frontend/src/types/api/licensesV3/getActive.ts:3

• Draft comment:
  Updated enum values: 'FAILED_PAYMENT' is replaced by 'DEFAULT' in LicenseEvent and 'PAYMENT_FAILED' by 'DEFAULTED' in LicenseState for consistency. Verify that both client and server agree on these new values.
• Reason this comment was not posted:
  Marked as duplicate.

Workflow ID: wflow_tqzjYLyJlAEfD6CL

---

Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

[ellipsis-dev]

👍 Looks good to me! Incremental review on b10baa1 in 21 seconds

More details

• Looked at 13 lines of code in 1 files
• Skipped 0 files when reviewing.
• Skipped posting 2 drafted comments based on config settings.

1. ee/query-service/model/license.go:142

• Draft comment:
  Ensure the new status value ('invalid') is consistently defined and used across the codebase; check that all references to the old 'inactive' state are updated.
• Reason this comment was not posted:
  Marked as duplicate.

2. ee/query-service/model/license.go:142

• Draft comment:
  Ensure the comment now using 'invalid' (instead of 'inactive') aligns with the defined constant LicenseStatusInvalid. This update appears correct as long as the business logic expects an invalid license to be treated as basic.
• Reason this comment was not posted:
  Comment did not seem useful. Confidence is useful = 0% <= threshold 50%
  The comment is asking the author to ensure that the change aligns with the business logic, which is against the rules. It is not making a specific code suggestion or asking for a test to be written. Therefore, it should be removed.

Workflow ID: wflow_jdvade5nu5j4x49Y

---

You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.