Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: aws integrations: ec2 and rds dashboards and collected metric details with gauges #7113

Merged

Conversation

raj-k-singh
Copy link
Collaborator

@raj-k-singh raj-k-singh commented Feb 14, 2025

Summary

Adds definition for gauge metrics based dashboards for EC2 and RDS and updates details of collected metrics.

Also updates the agent version to be used when connecting an account

Related Issues / PR's

contributes to https://github.com/SigNoz/engineering-pod/issues/2023


Important

Adds gauge metrics-based dashboards and updates collected metric details for AWS EC2 and RDS integrations, including agent version update.

  • Behavior:
    • Adds gauge metrics-based dashboards for EC2 (overview.json) and RDS (overview.json).
    • Updates collected metric details in integration.json for EC2 and RDS.
    • Updates agent version to 0.0.1 in controller.go.
  • Dashboards:
    • EC2 and RDS dashboards now use gauge metrics for various parameters like CPU utilization, EBS operations, and network traffic.
    • Adjusts layout and widget configurations in overview.json for both EC2 and RDS.
  • Metrics:
    • Changes metric types to Gauge for EC2 and RDS in integration.json.
    • Adds new metrics for network packets and status checks in EC2 integration.json.
  • Misc:
    • Updates telemetry collection strategies for EC2 and RDS in integration.json.

This description was created by Ellipsis for a893b39. It will automatically update as commits are pushed.

@github-actions github-actions bot added the chore label Feb 14, 2025
@raj-k-singh raj-k-singh marked this pull request as ready for review February 14, 2025 12:15
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to a893b39 in 1 minute and 21 seconds

More details
  • Looked at 4609 lines of code in 5 files
  • Skipped 0 files when reviewing.
  • Skipped posting 3 drafted comments based on config settings.
1. pkg/query-service/app/cloudintegrations/controller.go:127
  • Draft comment:
    The hard-coded agentVersion '0.0.1' is acceptable for now (as noted by the TODO), but ensure that in follow‐up changes it is parameterized or centrally managed so that version updates are consistent.
  • Reason this comment was not posted:
    Comment did not seem useful. Confidence is useful = 0% <= threshold 50%
    This comment is purely informative and suggests ensuring future changes, which violates the rules. It doesn't provide a specific code suggestion or ask for a test to be written.
2. pkg/query-service/app/cloudintegrations/serviceDefinitions/aws/ec2/assets/dashboards/overview.json:296
  • Draft comment:
    Typo in widget description: 'utilizaed' should be 'utilized'.
  • Reason this comment was not posted:
    Comment was on unchanged code.
3. pkg/query-service/app/cloudintegrations/serviceDefinitions/aws/rds/integration.json:775
  • Draft comment:
    Ensure consistency in metric naming conventions – the new metric names follow the aws_RDS_ pattern. Double‐check that all units and types (all now set to 'Gauge') align with your backend expectations.
  • Reason this comment was not posted:
    Comment was not on a location in the diff, so it can't be submitted as a review comment.

Workflow ID: wflow_QwSi0UO1Ovcd9dWb


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@raj-k-singh raj-k-singh merged commit 52f41e0 into main Feb 14, 2025
20 of 22 checks passed
@raj-k-singh raj-k-singh deleted the chore/aws-integrations-ec2-rds-dashboards-with-gauges branch February 14, 2025 13:10
hudsongeovane pushed a commit to hudsongeovane/signoz that referenced this pull request Feb 22, 2025
…details with gauges (SigNoz#7113)

* chore: aws integration: update agent version

* chore: aws integration: gauges based ec2 overview dashboard

* chore: aws integration: gauges based rds overview dashboard

* chore: aws integrations: ec2 metrics collected

* chore: aws integrations: rds metrics collected
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants