Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xen: remove the "skip the first token in the cmdline" from multiboot code path #517

Merged
merged 1 commit into from
Jun 1, 2022

Conversation

hannesm
Copy link
Contributor

@hannesm hannesm commented May 26, 2022

On recent QubesOS (4.1), this "opaque 'name'" is not present in the multiboot
cmdline.

//cc @xaki23 @palinp @marmarek

…code path

On recent QubesOS (4.1), this "opaque 'name'" is not present in the multiboot
cmdline.
@hannesm hannesm changed the title xen: remove the "skip the first tokn in the cmdline" from multiboot code path xen: remove the "skip the first token in the cmdline" from multiboot code path May 26, 2022
@palainp
Copy link
Contributor

palainp commented May 26, 2022

This code was originally in the virtio parse_multiboot, perhaps it is specific to virtio? From my observations, it seems safe to remove it here.

@hannesm hannesm mentioned this pull request May 27, 2022
@dinosaure dinosaure merged commit 1fbf6c9 into Solo5:master Jun 1, 2022
@dinosaure
Copy link
Collaborator

I will trust you @hannesm and @palainp about this patch as a non-user of Xen. Thanks!

@hannesm hannesm deleted the xen-multiboot branch June 3, 2022 11:16
dinosaure added a commit that referenced this pull request Oct 10, 2024
… executable

Tests expect only arguments on [cmdline] which is not true anymore for Xen and
Virtio according #584 & #517. This commit is a fix for tests for Xen and Virtio
cases.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants