Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update StackStorm HA installation instructions #1132

Merged
merged 9 commits into from
Jul 13, 2022
Merged

Update StackStorm HA installation instructions #1132

merged 9 commits into from
Jul 13, 2022

Conversation

mamercad
Copy link
Contributor

@mamercad mamercad commented Jul 9, 2022

Fixes #1131.

rush-skills
rush-skills requested changes Jul 10, 2022
View reviewed changes
@mamercad mamercad requested a review from rush-skills July 10, 2022 21:06
arm4b
arm4b suggested changes Jul 11, 2022
View reviewed changes
Copy link
Member

@arm4b arm4b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree with the previous PR review feedback.

Added a few more comments.

@mamercad mamercad requested a review from arm4b July 11, 2022 16:15
@mamercad mamercad requested a review from rush-skills July 12, 2022 21:38
arm4b
arm4b approved these changes Jul 13, 2022
View reviewed changes
Copy link
Member

@arm4b arm4b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Thanks for the fixes!

@mamercad
Copy link
Contributor Author

LGTM!

Thanks for the fixes!

FWIW; I used this to generate the terminal screenshot, nifty app.

@arm4b
Copy link
Member

arm4b commented Jul 13, 2022

It looks cool indeed 👍

@arm4b arm4b enabled auto-merge July 13, 2022 13:18
rush-skills
rush-skills approved these changes Jul 13, 2022
View reviewed changes
Copy link
Member

@rush-skills rush-skills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now, thanks for the contribution!

@arm4b arm4b merged commit 8c248db into StackStorm:master Jul 13, 2022
@mamercad mamercad deleted the issue-1131 branch July 13, 2022 21:02
@mamercad
Copy link
Contributor Author

It looks cool indeed 👍

Yep, makes it easy to get consistent terminal screenshots across your doc(s).

@arm4b arm4b mentioned this pull request Dec 19, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arm4b arm4b arm4b approved these changes

@rush-skills rush-skills rush-skills approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

StackStorm HA helm install instructions
3 participants
@mamercad @arm4b @rush-skills