Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JUnit 4.13 #131

Merged
merged 1 commit into from
Nov 2, 2020
Merged

JUnit 4.13 #131

merged 1 commit into from
Nov 2, 2020

Conversation

sullis
Copy link
Contributor

@sullis sullis commented Sep 5, 2020

Overview

upgrade to the latest version of JUnit 4.x


I hereby agree to the terms of the JUnit dataprovider Contributor License Agreement.


Definition of Done

  • There are no TODOs left in the code
  • Method preconditions are checked and documented in the method's Javadoc
  • Change is covered by automated tests (unit and/or integration tests)
  • Build has passed

@aaschmid
Copy link
Member

aaschmid commented Sep 5, 2020

Thanks for your PR @sullis. Can you please also update the CircleCI and Travis Builds such that 4.12 is still built and therefore checked for compatibility?

Edit:

@sullis sullis force-pushed the junit-4.13 branch 2 times, most recently from 829aea9 to 9375870 Compare September 5, 2020 17:24
@aaschmid
Copy link
Member

aaschmid commented Nov 1, 2020

@sullis: The build is still failing because of the deprecation of ExpectedException.none() method. Can you please add a @SuppressWarnings("deprecation") to all the usages such that the -Werror which I prefer will not trigger a warning here.

I want to keep the compatibility with 4.10 and above such that we cannot replace ExpectedException.none() with Assert.assertThrows which was created with 4.13.

Edit: Alternatively, you can allow me editing the source branch of the PR, see https://docs.github.com/en/free-pro-team@latest/github/collaborating-with-issues-and-pull-requests/allowing-changes-to-a-pull-request-branch-created-from-a-fork

@coveralls
Copy link

coveralls commented Nov 2, 2020

Coverage Status

Coverage remained the same at 92.681% when pulling f5f10fa on sullis:junit-4.13 into f7c9755 on TNG:master.

Signed-off-by: Sean C. Sullivan <[email protected]>
@sullis
Copy link
Contributor Author

sullis commented Nov 2, 2020

LGTM :)

@aaschmid aaschmid merged commit dc1d381 into TNG:master Nov 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants