-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix NoClassDefFoundError with JUnit 5.9 #137
Conversation
…nvoker class became an interface Signed-off-by: Jens Schulze <[email protected]>
Signed-off-by: Jens Schulze <[email protected]>
Signed-off-by: Jens Schulze <[email protected]>
Signed-off-by: Jens Schulze <[email protected]>
I changed the code from using the InterceptingExecutableInvoker to the DefaultExecutableInvoker as the last one is using the ExecutableInvoker interface. As already stated in the issue comment. It may be worth to investigate using the Invoker from the context object. I tried it, but seems that the context registry is not correctly filled necessary extensions so some tests failed. |
Thanks for the PR @jenschude. I will try to have a deeper look at this weekend... |
...r/src/main/java/com/tngtech/junit/dataprovider/UseDataProviderInvocationContextProvider.java
Outdated
Show resolved
Hide resolved
...r/src/main/java/com/tngtech/junit/dataprovider/UseDataProviderInvocationContextProvider.java
Show resolved
Hide resolved
Signed-off-by: Jens Schulze <[email protected]>
Thanks @jenschude, fixed with v2.10 which should appear shortly on Maven Central. |
Signed-off-by: Jens Schulze [email protected]
Overview
With version 5.9 of Junit Jupiter engine the ExecutableInvoker class became an interface.
Also the ConfigurationParameters got a new method
keySet
with 5.9.It should be noted that the API annotations by JUnit are not correct. The
keySet
method is annotated as available since 1.9 but has been introduced with 5.9 too.This change means that the minimum version for the dataprovider will be 5.9.0 for junit jupiter engine and parameters
Fixes #136
I hereby agree to the terms of the JUnit dataprovider Contributor License Agreement.
Definition of Done