-
-
Notifications
You must be signed in to change notification settings - Fork 366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(core): onSubmit meta #1167
base: main
Are you sure you want to change the base?
Conversation
View your CI Pipeline Execution ↗ for commit 650144d.
☁️ Nx Cloud last updated this comment at |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1167 +/- ##
=======================================
Coverage 88.32% 88.33%
=======================================
Files 27 27
Lines 1199 1200 +1
Branches 315 316 +1
=======================================
+ Hits 1059 1060 +1
Misses 125 125
Partials 15 15 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work!!
Just checking, do we want to make these changes? WDYT?
e7b8f31
to
c021d18
Compare
new branch after from #1131
From issue #989, this PR introduces onSubmitMeta to the formApi.
Example API shamelessly ripped from #989 and @crutchcorn