Spec the finally() operator
#153
Merged
+27
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Feb 21, 2025
See WICG/observable#153. This CL implements the `finally()` operator. It registers a callback which runs on both producer-initiated and consumer-initiated unsubscription. Its implementation is relatively straightforward, just utilizing the relevant subscriber's teardown list. This CL used to be really complicated, as was the spec PR. This has all been simplified since the factors that made it complicated (and broken) have been landed. See: - WICG/observable#151 (comment) - WICG/observable#154 - https://crrev.com/c/5676226 Now that the simplifying factors have been landed, this CL can proceed with a simple implementation, which passes all of the tests. [email protected] Bug: 40282760 Change-Id: Ifff220ec094abd2187f35020eae85c1bca502f89
aarongable
pushed a commit
to chromium/chromium
that referenced
this pull request
Feb 21, 2025
See WICG/observable#153. This CL implements the `finally()` operator. It registers a callback which runs on both producer-initiated and consumer-initiated unsubscription. Its implementation is relatively straightforward, just utilizing the relevant subscriber's teardown list. This CL used to be really complicated, as was the spec PR. This has all been simplified since the factors that made it complicated (and broken) have been landed. See: - WICG/observable#151 (comment) - WICG/observable#154 - https://crrev.com/c/5676226 Now that the simplifying factors have been landed, this CL can proceed with a simple implementation, which passes all of the tests. [email protected] Bug: 40282760 Change-Id: Ifff220ec094abd2187f35020eae85c1bca502f89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5654720 Reviewed-by: Di Zhang <[email protected]> Commit-Queue: Dominic Farolino <[email protected]> Cr-Commit-Position: refs/heads/main@{#1423349}
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Feb 21, 2025
See WICG/observable#153. This CL implements the `finally()` operator. It registers a callback which runs on both producer-initiated and consumer-initiated unsubscription. Its implementation is relatively straightforward, just utilizing the relevant subscriber's teardown list. This CL used to be really complicated, as was the spec PR. This has all been simplified since the factors that made it complicated (and broken) have been landed. See: - WICG/observable#151 (comment) - WICG/observable#154 - https://crrev.com/c/5676226 Now that the simplifying factors have been landed, this CL can proceed with a simple implementation, which passes all of the tests. [email protected] Bug: 40282760 Change-Id: Ifff220ec094abd2187f35020eae85c1bca502f89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5654720 Reviewed-by: Di Zhang <[email protected]> Commit-Queue: Dominic Farolino <[email protected]> Cr-Commit-Position: refs/heads/main@{#1423349}
benlesh
requested changes
Feb 21, 2025
benlesh
approved these changes
Feb 21, 2025
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Feb 21, 2025
See WICG/observable#153. This CL implements the `finally()` operator. It registers a callback which runs on both producer-initiated and consumer-initiated unsubscription. Its implementation is relatively straightforward, just utilizing the relevant subscriber's teardown list. This CL used to be really complicated, as was the spec PR. This has all been simplified since the factors that made it complicated (and broken) have been landed. See: - WICG/observable#151 (comment) - WICG/observable#154 - https://crrev.com/c/5676226 Now that the simplifying factors have been landed, this CL can proceed with a simple implementation, which passes all of the tests. [email protected] Bug: 40282760 Change-Id: Ifff220ec094abd2187f35020eae85c1bca502f89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5654720 Reviewed-by: Di Zhang <[email protected]> Commit-Queue: Dominic Farolino <[email protected]> Cr-Commit-Position: refs/heads/main@{#1423349}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR specs the
finally()operator, registering the callback to its internal Subscriber's teardown list.Mirroring thefinallykeyword, its semantics are such that on both producer-initiated and consumer-initiated unsubscription, the finally operator's callback runs. The only remaining open question about this operator has to do with subtle timing between the finally() operator and source Observable teardown execution. See #151 for discussion there. I don't think that needs to block this PR, but it does need to resolve one way or another.The above issues are struckthrough and obsolete; see #151 (comment).
Tests are being landed in https://chromium-review.googlesource.com/c/chromium/src/+/5654720.
Preview | Diff