Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pages upload #7

Closed
a-recknagel opened this issue Sep 19, 2019 · 0 comments · Fixed by #8
Closed

Fix pages upload #7

a-recknagel opened this issue Sep 19, 2019 · 0 comments · Fixed by #8
Labels
bug Something isn't working

Comments

@a-recknagel
Copy link
Owner

a-recknagel commented Sep 19, 2019

The release_docs steps in the main workflow also has an action where the documentation is pushed to the pages branch, and a rebuild of the pages domain is triggered which loads its content.

When checking its current state (the build triggered by 55d6e05) as opposed to what's visible when downloading the artifact and opening its index.html in a browser, there seem to be some ... discrepancies:


Opening artifacts in browser:
Screenshot from 2019-09-19 09-10-17


What's visible in gh-pages:
Screenshot from 2019-09-19 09-09-14

Some things like linking to source code also plain don't work.

@a-recknagel a-recknagel added the bug Something isn't working label Sep 19, 2019
a-recknagel added a commit that referenced this issue Sep 20, 2019
closes #7

Motivated by #5, I don't think this proposal is specific enough to close it just yet.

A lot of other stuff has also made it into this PR:

 -   small fixes to the workflow file, yaml is a way too permissive format
 -   pushing the docs to gh-pages on every PR merge
 -   adding a bunch of badges to the readme
 -   restoring the "documentation" section to TOOLING.rst
 -   changing the docs look to the flask theme, because I like it better than alabaster
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant