Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the dependency on counsel-imenu optional #611

Closed
wants to merge 2 commits into from

Conversation

akirak
Copy link
Contributor

@akirak akirak commented Oct 6, 2021

This aims to resolve #610. It allows the user to replace counsel-imenu with something else by customizing lispy-imenu-function variable.

Note that the user will have to install counsel separately to use the default setting. I am not sure if this is right. Please feel free to amend this PR.

@aaronjensen
Copy link
Contributor

This is great, if this gets accepted it would be nice to do a similar thing with swiper.

@akirak
Copy link
Contributor Author

akirak commented Oct 25, 2021

This is great, if this gets accepted it would be nice to do a similar thing with swiper.

@aaronjensen Thanks for the comment, but I don't think it is possible with swiper, due to its tight integration with ivy.

I am not still sure if @abo-abo will accept this PR. Because the dependency on counsel is removed here, it will become necessary for users to install counsel separately. It would be nice if there were a better way to declare the dependency.

@aaronjensen
Copy link
Contributor

@akirak Right -- ideally ivy would be optional too, but I realize that's likely a bridge too far.

@benjamin-asdf
Copy link

benjamin-asdf commented Nov 15, 2021

I second making ivy optional as well. Isnt't the only usage lispy-occur?

@akirak
Copy link
Contributor Author

akirak commented Dec 15, 2021

I now don't mind having the ivy dependency. If you don't like this change, please close the PR.

@abo-abo abo-abo closed this in 87cbf9d Dec 30, 2021
@abo-abo
Copy link
Owner

abo-abo commented Dec 30, 2021

Merged, thanks.

@akirak akirak deleted the remove-counsel-dep branch December 31, 2021 15:56
papercatlol pushed a commit to papercatlol/lispy that referenced this pull request Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow replacing counsel with something else
4 participants