-
Notifications
You must be signed in to change notification settings - Fork 7.6k
Conversation
@@ -403,7 +403,7 @@ define({ | |||
"RELAUNCH_CHROME" : "Relaunch Chrome", | |||
"ABOUT" : "About", | |||
"CLOSE" : "Close", | |||
"ABOUT_TEXT_LINE1" : "sprint {VERSION_MINOR} {BUILD_TYPE} {VERSION}", | |||
"ABOUT_TEXT_LINE1" : "release {VERSION_MAJOR}.{VERSION_MINOR} {BUILD_TYPE} {VERSION}", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should it be uppercase?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I think it should be "Release".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed.
@marcelgerber Thanks for looking at this. There is a similar |
@ingorichter Does this have any implications with how builds are deployed on brackets.io or the update-notification server? |
@redmunds They don't depend on each other, do they? I'm not super used to brackets-shell, and we need another PR there anyway. The trello card linked above mentions some other changes to be done there as well. @peterflynn Probably not. They already use names like "Release 0.xx" and don't depend on the changes here (which are a Grunt task rename and a UI string change). |
@peterflynn No, the information for brackets.io is coming from the update notifications. These changes won't break any deployment of new builds. |
@marcelgerber We definitely want to update both brackets and brackets-shell, so might as well do them together. Take a look at this pull request to see the files that are updated. They are all data files, so it should be straight forward. |
I'm going to merge #8680 and adobe/brackets-shell#462 after the release of 43. I need to make small breaking changes to the build machine setup. |
@ingorichter Since you are looking at this, you should take the "Run |
Thanks @marcelgerber |
For #7828 and https://trello.com/c/atMTdx6l/1313-brackets-7828-should-be-consistent-about-release-vs-sprint-issue
Replaces most of the occurences of
Sprint
withRelease
, maybe even too many.The only ones I left in place were some unit tests and the non-English translations (to be translated).