Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port to Vaadin 8 #56

Merged
merged 1 commit into from
Mar 26, 2017
Merged

Port to Vaadin 8 #56

merged 1 commit into from
Mar 26, 2017

Conversation

willtemperley
Copy link
Contributor

I just did a quick and brutal port to Vaadin 8. I removed all deprecated methods. It's not fully tested but the demo app shows most functionality remains intact.

@AemonAlgiz
Copy link

AemonAlgiz commented Mar 20, 2017

Hey Will,

You may want to consider uploading this to the Vaadin Directory. It looks like the original author no longer has the time to maintain this what-so-ever and exposing the updated code may make for more contributions.

@ahn
Copy link
Owner

ahn commented Mar 22, 2017

Hi, sorry I've been absent. I'll take a look at this on the weekend and hopefully can upload Vaadin 8 version to the Directory.

@willtemperley
Copy link
Contributor Author

@AemonAlgiz another option might be publishing to Maven Central or JCenter. I've not done it before but it might provide the option of multiple authors per project. For me this is a constant issue with the Vaadin setup, which is fine for single dev projects, but multiple authors or handing over ownership isn't officially supported. Second, JCenter seems to provide better CI capabilities.

@ahn ahn merged commit 01c59e9 into ahn:master Mar 26, 2017
@ahn
Copy link
Owner

ahn commented Mar 26, 2017

Version 0.8.15 of this add-on for Vaadin 8 is now at Vaadin Directory, thanks willtemperley.

I didn't test it very thoroughly, the basic stuff seems to work anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants