🐛 Source Facebook Marketing : Fix retry pattern #54171
Open
+60
−59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@NahidOulmi is attempting to deploy a commit to the Airbyte Growth Team on Vercel. A member of the Team first needs to authorize it. |
octavia-squidington-iii
added
area/connectors
NahidOulmi
had a problem deploying
to
community-ci
GitHub Actions
Error
NahidOulmi
had a problem deploying
to
community-ci-auto
GitHub Actions
Error
NahidOulmi
had a problem deploying
to
community-ci
GitHub Actions
Error
NahidOulmi
temporarily deployed
to
community-ci
GitHub Actions
Inactive
NahidOulmi
temporarily deployed
to
community-ci-auto
GitHub Actions
Inactive
NahidOulmi
temporarily deployed
to
community-ci
GitHub Actions
Inactive
1 task
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
marcosmarxm
approved these changes
Feb 21, 2025
There was a problem hiding this comment.
From what I can identify the chance is correct. @bazarnov can you take a look as you're the last to make changes in this Facebook logic?
|
@NahidOulmi thanks for the fix, running tests! |
lazebnyi
approved these changes
Feb 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
The retry pattern was dividing the request limit by 2 at each failed retry but was not setting back to default settings if the retry succeeded
How
There was a typo in the
common.pyfile.last_api_call_is_successfulwas written with two Ls but it's defined with one L in theMyFacebookAdsApiclass.User Impact
The syncs in the Source Facebook Marketing connector should work better.
Can this PR be safely reverted and rolled back?