Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update digits demo #58

Merged
merged 5 commits into from
Dec 9, 2020
Merged

Update digits demo #58

merged 5 commits into from
Dec 9, 2020

Conversation

danielfrg
Copy link
Contributor

Updating the digits recognition demo

  • Updated the workflow to the new UI, forms and stuff
  • Added instructions on the environment selection
  • Updated and pinned the dependencies so it works with the python 3.7 environment
  • Changed the serialisation format to joblib, this is the recommended by scikit-learn
  • Added two query options, url and base64 encoded image

@danielfrg danielfrg requested a review from a team as a code owner December 8, 2020 22:18
@danielfrg danielfrg mentioned this pull request Dec 8, 2020
Closed
koverholt
koverholt approved these changes Dec 8, 2020
View reviewed changes
Copy link
Contributor

@koverholt koverholt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just some minor edits. Thanks! And the url vs. base64 options are nice!

@koverholt
Copy link
Contributor

You can also close this issue in the dev-center repo (algorithmiaio/dev-center#342) with this PR and #57.

@koverholt
Copy link
Contributor

Actually, let's leave algorithmiaio/dev-center#342 open and I'll add a comment there that the code example is fixed, so we can figure out what to to about the outdated docs there (e.g., just link to the READMEs in this repo).

@koverholt koverholt mentioned this pull request Dec 8, 2020
Open
bnlb
bnlb approved these changes Dec 9, 2020
View reviewed changes
Copy link
Contributor

@bnlb bnlb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚡

@danielfrg
Copy link
Contributor Author

Thanks for the fix and review :D

@danielfrg danielfrg merged commit 8e8fbb8 into master Dec 9, 2020
@danielfrg danielfrg deleted the update-digits-demo branch December 9, 2020 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@koverholt koverholt koverholt approved these changes

@bnlb bnlb bnlb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@danielfrg @koverholt @bnlb