fix(migrations): account for let declarations in control flow migrati…

…on (#59861) Fixes that the control flow migration wasn't accounting for `@let` when determining which symbols are used. PR Close #59861
angular · Feb 12, 2025 · aa285c5 · aa285c5
1 parent 1119f85
commit aa285c5
Show file tree

Hide file tree

Showing 2 changed files with 41 additions and 0 deletions.
diff --git a/packages/core/schematics/ng-generate/control-flow-migration/types.ts b/packages/core/schematics/ng-generate/control-flow-migration/types.ts
@@ -10,6 +10,7 @@ import {
   Attribute,
   Block,
   Element,
+  LetDeclaration,
   ParseTreeResult,
   RecursiveVisitor,
   Text,
@@ -399,6 +400,13 @@ export class CommonCollector extends RecursiveVisitor {
     }
   }
 
+  override visitLetDeclaration(decl: LetDeclaration): void {
+    if (this.hasPipes(decl.value)) {
+      this.count++;
+    }
+    super.visitLetDeclaration(decl, null);
+  }
+
   private hasDirectives(input: string): boolean {
     return commonModuleDirectives.has(input);
   }

diff --git a/packages/core/schematics/test/control_flow_migration_spec.ts b/packages/core/schematics/test/control_flow_migration_spec.ts
@@ -6512,6 +6512,39 @@ describe('control flow migration', () => {
 
       expect(actual).toBe(expected);
     });
+
+    it('should not remove common module if symbols are used inside @let', async () => {
+      writeFile(
+        '/comp.ts',
+        [
+          `import {CommonModule} from '@angular/common';`,
+          `import {Component} from '@angular/core';\n`,
+          `@Component({`,
+          `  imports: [CommonModule],`,
+          `  template: \`@let foo = 123 | date; <span *ngIf="foo">{{foo}}</span>\``,
+          `})`,
+          `class Comp {`,
+          `  toggle = false;`,
+          `}`,
+        ].join('\n'),
+      );
+
+      await runMigration();
+      const actual = tree.readContent('/comp.ts');
+      const expected = [
+        `import {CommonModule} from '@angular/common';`,
+        `import {Component} from '@angular/core';\n`,
+        `@Component({`,
+        `  imports: [CommonModule],`,
+        `  template: \`@let foo = 123 | date; @if (foo) {<span>{{foo}}</span>}\``,
+        `})`,
+        `class Comp {`,
+        `  toggle = false;`,
+        `}`,
+      ].join('\n');
+
+      expect(actual).toBe(expected);
+    });
   });
 
   describe('no migration needed', () => {