mssql_script: make module Python 2 compatible #7821
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felixfontein
added
backport-7
backport-8
1 task
ansibullbot
added
bug
markuman
approved these changes
Jan 17, 2024
Backport to stable-7: 💚 backport PR created✅ Backport PR branch: Backported as #7865 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
Jan 18, 2024
Make module Python 2 compatible. (cherry picked from commit 92f8bf7)
|
@markuman thanks for reviewing this! |
Backport to stable-8: 💚 backport PR created✅ Backport PR branch: Backported as #7866 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
Jan 18, 2024
Make module Python 2 compatible. (cherry picked from commit 92f8bf7)
felixfontein
added a commit
that referenced
this pull request
Jan 18, 2024
…on 2 compatible (#7865) mssql_script: make module Python 2 compatible (#7821) Make module Python 2 compatible. (cherry picked from commit 92f8bf7) Co-authored-by: Felix Fontein <[email protected]>
felixfontein
added a commit
that referenced
this pull request
Jan 18, 2024
…on 2 compatible (#7866) mssql_script: make module Python 2 compatible (#7821) Make module Python 2 compatible. (cherry picked from commit 92f8bf7) Co-authored-by: Felix Fontein <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
splitlines()does not accept kwargs on Python 2, only positional parameters.Fixes #7818.
ISSUE TYPE
COMPONENT NAME
mssql_script