Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing id parameter into pacman_key documentation examples. #7855

Merged
merged 1 commit into from
Jan 18, 2024

Conversation

QazerLab
Copy link
Contributor

@QazerLab QazerLab commented Jan 17, 2024

Key ID is a mandatory parameter, and the examples which miss it are incorrect.

SUMMARY

The documentation for pacman_key module includes incorrect examples which miss key ID. Given that key ID is a mandatory parameter (and the documentation clearly states this), the examples missing the key need to be fixed.

ISSUE TYPE
  • Docs Pull Request
COMPONENT NAME

modules/pacman_key

Key ID is a mandatory parameter, and the examples which miss it are
incorrect.
@ansibullbot
Copy link
Collaborator

@ansibullbot ansibullbot added docs docs_only module module new_contributor Help guide this first time contributor plugins plugin (any type) small_patch Hopefully easy to review labels Jan 17, 2024
@felixfontein felixfontein added backport-7 backport-8 Automatically create a backport for the stable-8 branch labels Jan 18, 2024
@felixfontein felixfontein merged commit cd77d67 into ansible-collections:main Jan 18, 2024
121 checks passed
Copy link

patchback bot commented Jan 18, 2024

Backport to stable-7: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-7/cd77d67efb7d2f1f79d48d5a03f427d4445cd59e/pr-7855

Backported as #7867

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Jan 18, 2024
…7855)

Key ID is a mandatory parameter, and the examples which miss it are
incorrect.

(cherry picked from commit cd77d67)
@felixfontein
Copy link
Collaborator

@QazerLab thanks a lot for fixing this!

Copy link

patchback bot commented Jan 18, 2024

Backport to stable-8: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-8/cd77d67efb7d2f1f79d48d5a03f427d4445cd59e/pr-7855

Backported as #7868

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Jan 18, 2024
…7855)

Key ID is a mandatory parameter, and the examples which miss it are
incorrect.

(cherry picked from commit cd77d67)
felixfontein pushed a commit that referenced this pull request Jan 18, 2024
…o pacman_key documentation examples. (#7867)

Add missing `id` parameter into pacman_key documentation examples. (#7855)

Key ID is a mandatory parameter, and the examples which miss it are
incorrect.

(cherry picked from commit cd77d67)

Co-authored-by: Danila Kiver <[email protected]>
felixfontein pushed a commit that referenced this pull request Jan 18, 2024
…o pacman_key documentation examples. (#7868)

Add missing `id` parameter into pacman_key documentation examples. (#7855)

Key ID is a mandatory parameter, and the examples which miss it are
incorrect.

(cherry picked from commit cd77d67)

Co-authored-by: Danila Kiver <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-8 Automatically create a backport for the stable-8 branch docs_only docs module module new_contributor Help guide this first time contributor plugins plugin (any type) small_patch Hopefully easy to review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants