-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add systemd run0 as a become method #8306
Conversation
Signed-off-by: Thomas Sjögren <[email protected]>
Signed-off-by: Thomas Sjögren <[email protected]>
Signed-off-by: Thomas Sjögren <[email protected]>
Signed-off-by: Thomas Sjögren <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution! Please note that you need to add tests. (Most other become plugins use unit tests to ensure that the correct command line is built, that's probably a good idea here as well.)
Signed-off-by: Thomas Sjögren <[email protected]>
Signed-off-by: Thomas Sjögren <[email protected]>
Signed-off-by: Thomas Sjögren <[email protected]>
Signed-off-by: Thomas Sjögren <[email protected]>
Signed-off-by: Thomas Sjögren <[email protected]>
Signed-off-by: Thomas Sjögren <[email protected]>
unit test will be fixed and extended |
Signed-off-by: Thomas Sjögren <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! If nobody objects, I'll merge this in ~a week.
The CI failures are unrelated. |
d347bf5
into
ansible-collections:main
@konstruktoid thanks for your contribution! |
* add systemd run0 as a become method Signed-off-by: Thomas Sjögren <[email protected]> * add fragment Signed-off-by: Thomas Sjögren <[email protected]> * remove space after hyphen Signed-off-by: Thomas Sjögren <[email protected]> * replace ansible with collection version Signed-off-by: Thomas Sjögren <[email protected]> * update version_added and remove changelog fragment Signed-off-by: Thomas Sjögren <[email protected]> * update formating Signed-off-by: Thomas Sjögren <[email protected]> * add types Signed-off-by: Thomas Sjögren <[email protected]> * slim super() Signed-off-by: Thomas Sjögren <[email protected]> * imports must appear below docs Signed-off-by: Thomas Sjögren <[email protected]> * add initial unit test Signed-off-by: Thomas Sjögren <[email protected]> * update unit tests Signed-off-by: Thomas Sjögren <[email protected]> --------- Signed-off-by: Thomas Sjögren <[email protected]>
* add systemd run0 as a become method Signed-off-by: Thomas Sjögren <[email protected]> * add fragment Signed-off-by: Thomas Sjögren <[email protected]> * remove space after hyphen Signed-off-by: Thomas Sjögren <[email protected]> * replace ansible with collection version Signed-off-by: Thomas Sjögren <[email protected]> * update version_added and remove changelog fragment Signed-off-by: Thomas Sjögren <[email protected]> * update formating Signed-off-by: Thomas Sjögren <[email protected]> * add types Signed-off-by: Thomas Sjögren <[email protected]> * slim super() Signed-off-by: Thomas Sjögren <[email protected]> * imports must appear below docs Signed-off-by: Thomas Sjögren <[email protected]> * add initial unit test Signed-off-by: Thomas Sjögren <[email protected]> * update unit tests Signed-off-by: Thomas Sjögren <[email protected]> --------- Signed-off-by: Thomas Sjögren <[email protected]>
SUMMARY
This PR adds support for
run0
as a become method.run0
will be available in systemd 256, see https://mastodon.social/@pid_eins/112353324518585654ISSUE TYPE
COMPONENT NAME
community.general.run0