Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add systemd run0 as a become method #8306

Merged
merged 11 commits into from
May 11, 2024

Conversation

konstruktoid
Copy link
Contributor

SUMMARY

This PR adds support for run0 as a become method.
run0 will be available in systemd 256, see https://mastodon.social/@pid_eins/112353324518585654

ISSUE TYPE
  • New Module/Plugin Pull Request
COMPONENT NAME

community.general.run0

Signed-off-by: Thomas Sjögren <[email protected]>
Signed-off-by: Thomas Sjögren <[email protected]>
Copy link
Collaborator

@felixfontein felixfontein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! Please note that you need to add tests. (Most other become plugins use unit tests to ensure that the correct command line is built, that's probably a good idea here as well.)

@felixfontein felixfontein added the check-before-release PR will be looked at again shortly before release and merged if possible. label May 4, 2024
@ansibullbot ansibullbot added become become plugin plugins plugin (any type) labels May 4, 2024
Signed-off-by: Thomas Sjögren <[email protected]>
Signed-off-by: Thomas Sjögren <[email protected]>
Signed-off-by: Thomas Sjögren <[email protected]>
Signed-off-by: Thomas Sjögren <[email protected]>
@ansibullbot ansibullbot added the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR label May 4, 2024
Signed-off-by: Thomas Sjögren <[email protected]>
@ansibullbot ansibullbot added new_plugin New plugin tests tests unit tests/unit labels May 4, 2024
@konstruktoid
Copy link
Contributor Author

unit test will be fixed and extended

Signed-off-by: Thomas Sjögren <[email protected]>
Copy link
Collaborator

@felixfontein felixfontein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! If nobody objects, I'll merge this in ~a week.

@felixfontein felixfontein removed the check-before-release PR will be looked at again shortly before release and merged if possible. label May 11, 2024
@felixfontein
Copy link
Collaborator

The CI failures are unrelated.

@felixfontein felixfontein merged commit d347bf5 into ansible-collections:main May 11, 2024
128 of 133 checks passed
@felixfontein
Copy link
Collaborator

@konstruktoid thanks for your contribution!

@konstruktoid konstruktoid deleted the run0 branch May 12, 2024 11:05
austinlucaslake pushed a commit to austinlucaslake/community.general that referenced this pull request May 25, 2024
* add systemd run0 as a become method

Signed-off-by: Thomas Sjögren <[email protected]>

* add fragment

Signed-off-by: Thomas Sjögren <[email protected]>

* remove space after hyphen

Signed-off-by: Thomas Sjögren <[email protected]>

* replace ansible with collection version

Signed-off-by: Thomas Sjögren <[email protected]>

* update version_added and remove changelog fragment

Signed-off-by: Thomas Sjögren <[email protected]>

* update formating

Signed-off-by: Thomas Sjögren <[email protected]>

* add types

Signed-off-by: Thomas Sjögren <[email protected]>

* slim super()

Signed-off-by: Thomas Sjögren <[email protected]>

* imports must appear below docs

Signed-off-by: Thomas Sjögren <[email protected]>

* add initial unit test

Signed-off-by: Thomas Sjögren <[email protected]>

* update unit tests

Signed-off-by: Thomas Sjögren <[email protected]>

---------

Signed-off-by: Thomas Sjögren <[email protected]>
Massl123 pushed a commit to Massl123/community.general that referenced this pull request Feb 7, 2025
* add systemd run0 as a become method

Signed-off-by: Thomas Sjögren <[email protected]>

* add fragment

Signed-off-by: Thomas Sjögren <[email protected]>

* remove space after hyphen

Signed-off-by: Thomas Sjögren <[email protected]>

* replace ansible with collection version

Signed-off-by: Thomas Sjögren <[email protected]>

* update version_added and remove changelog fragment

Signed-off-by: Thomas Sjögren <[email protected]>

* update formating

Signed-off-by: Thomas Sjögren <[email protected]>

* add types

Signed-off-by: Thomas Sjögren <[email protected]>

* slim super()

Signed-off-by: Thomas Sjögren <[email protected]>

* imports must appear below docs

Signed-off-by: Thomas Sjögren <[email protected]>

* add initial unit test

Signed-off-by: Thomas Sjögren <[email protected]>

* update unit tests

Signed-off-by: Thomas Sjögren <[email protected]>

---------

Signed-off-by: Thomas Sjögren <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
become become plugin needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR new_plugin New plugin plugins plugin (any type) tests tests unit tests/unit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants