cloudflare_dns: add support for comment and tags
#9132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibullbot
added
feature
This comment was marked as outdated.
This comment was marked as outdated.
ansibullbot
added
ci_verified
ansibullbot
removed
ci_verified
felixfontein
added
check-before-release
|
Hi @Sergio-IME Other than the comments already left by Felix, it looks good to me. Cheers, AZ PS: "IME" as in "IME-USP" ? |
|
Hi
last commits address the changes, not sure why they aren't detected as outdated hmm
no, not related 🙂 |
|
If nobody objects, I'll merge this at the end of this week! |
russoz
reviewed
Nov 18, 2024
| @@ -826,6 +876,10 @@ def ensure_dns_record(self, **kwargs): | |||
| do_update = True | |||
| if (params['type'] == 'CNAME') and (cur_record['content'] != new_record['content']): | |||
| do_update = True | |||
| if cur_record['comment'] != new_record['comment']: | |||
| do_update = True | |||
| if sorted(cur_record['tags']) != sorted(new_record['tags']): | |||
There was a problem hiding this comment.
No particular preference, just a note that this could be also achieved by:
Suggested change
| if sorted(cur_record['tags']) != sorted(new_record['tags']): | |
| if set(cur_record['tags']) != set(new_record['tags']): |
russoz
approved these changes
Nov 18, 2024
felixfontein
removed
the
check-before-release
Backport to stable-10: 💚 backport PR created✅ Backport PR branch: Backported as #9184 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
Nov 24, 2024
* `cloudflare_dns`: add support for `comment` and `tags` * `cloudflare_dns`: add return values for `comment`/`tags` fields * `cloudflare_dns`: fix return values samples * `cloudflare_dns`: changelog fragment formatting * `cloudflare_dns`: add missing `version_added` * `cloudflare_dns`: remove explicit `required: false` * `cloudflare_dns`: empty `comment` idempotency fix (cherry picked from commit 3c23ce4)
|
@Sergio-IME thanks for your contribution! |
felixfontein
pushed a commit
that referenced
this pull request
Nov 25, 2024
… for `comment` and `tags` (#9184) `cloudflare_dns`: add support for `comment` and `tags` (#9132) * `cloudflare_dns`: add support for `comment` and `tags` * `cloudflare_dns`: add return values for `comment`/`tags` fields * `cloudflare_dns`: fix return values samples * `cloudflare_dns`: changelog fragment formatting * `cloudflare_dns`: add missing `version_added` * `cloudflare_dns`: remove explicit `required: false` * `cloudflare_dns`: empty `comment` idempotency fix (cherry picked from commit 3c23ce4) Co-authored-by: Sergio <[email protected]>
Massl123
pushed a commit
to Massl123/community.general
that referenced
this pull request
Feb 7, 2025
…ctions#9132) * `cloudflare_dns`: add support for `comment` and `tags` * `cloudflare_dns`: add return values for `comment`/`tags` fields * `cloudflare_dns`: fix return values samples * `cloudflare_dns`: changelog fragment formatting * `cloudflare_dns`: add missing `version_added` * `cloudflare_dns`: remove explicit `required: false` * `cloudflare_dns`: empty `comment` idempotency fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Add support for
commentandtagsfields to Cloudflare DNS module as it's allowed by their API https://developers.cloudflare.com/api/operations/dns-records-for-a-zone-create-dns-recordISSUE TYPE
COMPONENT NAME
cloudflare_dns
ADDITIONAL INFORMATION