Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid permalink icon to be selectable #194

Closed

Conversation

felixfontein
Copy link
Collaborator

@acozine
Copy link

acozine commented Aug 7, 2023

LGTM, but I did not test it.

@samccann
Copy link
Contributor

samccann commented Aug 7, 2023

Okay I figured out how to test this locally, but now I don't know what page shows this problem? I thought it was the parameters table but those don't copy the link when I doubleclick on them even w/o this patch...

@felixfontein
Copy link
Collaborator Author

Hmm, actually this doesn't seem to be necessary at all. According to https://developer.mozilla.org/en-US/docs/Web/CSS/user-select#values, the default value is auto, and that means for ::after that the text isn't selectable anyway.

The permalink icon reported in the original issue isn't in ::after, but a regular DOM element.

I'll close this PR. Thanks everyone!

@felixfontein felixfontein deleted the select-permalink branch August 7, 2023 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants