[pre-commit.ci] pre-commit autoupdate (#142)

* [pre-commit.ci] pre-commit autoupdate

updates:
- https://github.com/pre-commit/mirrors-isort → https://github.com/PyCQA/isort
- [github.com/PyCQA/isort: v5.9.3 → 5.9.3](PyCQA/isort@v5.9.3...5.9.3)
- https://github.com/python/black.git → https://github.com/psf/black
- [github.com/psf/black: 21.7b0 → 21.9b0](psf/black@21.7b0...21.9b0)
- https://gitlab.com/pycqa/flake8.git → https://github.com/PyCQA/flake8
- [github.com/PyCQA/flake8: 3.9.2 → 4.0.1](PyCQA/flake8@3.9.2...4.0.1)
- [github.com/ansible/ansible-lint.git: v5.1.2 → v5.2.0](https://github.com/ansible/ansible-lint.git/compare/v5.1.2...v5.2.0)
- [github.com/pre-commit/mirrors-mypy: v0.910 → v0.910-1](pre-commit/mirrors-mypy@v0.910...v0.910-1)
- [github.com/PyCQA/pylint: v2.10.2 → v2.11.1](pylint-dev/pylint@v2.10.2...v2.11.1)

* Linting fixes

* Avoided lru_cache due mypy problems

python/mypy#5107

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Sorin Sbarnea <[email protected]>

.pre-commit-config.yaml

@@ -17,12 +17,12 @@ repos:
     hooks:
       - id: isort
   - repo: https://github.com/psf/black
-    rev: 22.3.0
+    rev: 22.6.0
     hooks:
       - id: black
         language_version: python3
   - repo: https://github.com/pre-commit/pre-commit-hooks.git
-    rev: v4.2.0
+    rev: v4.3.0
     hooks:
       - id: end-of-file-fixer
       - id: trailing-whitespace
@@ -41,8 +41,8 @@ repos:
           - flake8-absolute-import>=1.0
           - flake8-docstrings>=1.6.0
         language_version: python3
-  - repo: https://github.com/ansible-community/ansible-lint.git
-    rev: v6.0.2
+  - repo: https://github.com/ansible/ansible-lint.git
+    rev: v6.3.0
     hooks:
       - id: ansible-lint
         always_run: true
@@ -52,7 +52,7 @@ repos:
           - ansible-core>=2.11
           - yamllint
   - repo: https://github.com/pre-commit/mirrors-mypy
-    rev: v0.942
+    rev: v0.961
     hooks:
       - id: mypy
         # empty args needed in order to match mypy cli behavior
@@ -65,7 +65,7 @@ repos:
           - packaging
           - types-requests
   - repo: https://github.com/PyCQA/pylint
-    rev: v2.13.5
+    rev: v2.14.4
     hooks:
       - id: pylint
         additional_dependencies:

.pylintrc

@@ -4,7 +4,6 @@ disable =
     # TODO(ssbarnea): remove temporary skips adding during initial adoption:
     abstract-method,
     arguments-differ,
-    bad-continuation,
     broad-except,
     consider-merging-isinstance,
     consider-using-in,

src/molecule_docker/driver.py

@@ -24,7 +24,6 @@
 import os
 from typing import Dict
 
-from ansible_compat.ports import cache
 from molecule import logger
 from molecule.api import Driver
 from molecule.util import sysexit_with_message
@@ -183,6 +182,8 @@ class Docker(Driver):
     .. _`CMD`: https://docs.docker.com/engine/reference/builder/#cmd
     """  # noqa
 
+    _passed_sanity = False
+
     def __init__(self, config=None):
         """Construct Docker."""
         super(Docker, self).__init__(config)
@@ -224,11 +225,12 @@ def ansible_connection_options(self, instance_name):
             x["ansible_docker_extra_args"] = f"-H={os.environ['DOCKER_HOST']}"
         return x
 
-    @cache
     def sanity_checks(self):
         """Implement Docker driver sanity checks."""
-        log.info("Sanity checks: '%s'", self._name)
+        if self._passed_sanity:
+            return
 
+        log.info("Sanity checks: '%s'", self._name)
         try:
             import docker
             import requests
@@ -243,6 +245,8 @@ def sanity_checks(self):
             )
             sysexit_with_message(msg)
 
+        self._passed_sanity = True
+
     def reset(self):
         import docker