Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AMORO-2960] Support paimon s3 based catalog #2972

Merged
merged 2 commits into from
Jun 28, 2024
Merged

[AMORO-2960] Support paimon s3 based catalog #2972

merged 2 commits into from
Jun 28, 2024

Conversation

xleoken
Copy link
Member

@xleoken xleoken commented Jun 27, 2024 •
edited
Loading

Why are the changes needed?

Close #2960.

Brief change log

Support paimon s3 based catalog

image

image

image

image

How was this patch tested?

  • Add some test cases that check the changes thoroughly including negative and positive cases if possible

  • Add screenshots for manual tests if appropriate

  • Run test locally before making a pull request

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@github-actions github-actions bot added module:core Core module module:ams-server Ams server module type:build module:ams-dashboard Ams dashboard module labels Jun 27, 2024
@xleoken xleoken force-pushed the paimon-filesystem branch from 093698b to f937383 Compare June 27, 2024 05:45
This was referenced Jun 27, 2024
Closed
Closed
@xleoken xleoken force-pushed the paimon-filesystem branch from f937383 to 3bdbd67 Compare June 27, 2024 05:58
baiyangtx
baiyangtx reviewed Jun 27, 2024
View reviewed changes
baiyangtx
baiyangtx approved these changes Jun 27, 2024
View reviewed changes
Copy link
Contributor

@baiyangtx baiyangtx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for your contribution.

zhoujinsong
zhoujinsong reviewed Jun 27, 2024
View reviewed changes
Copy link
Contributor

@zhoujinsong zhoujinsong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution, I left a comment, PTAL.

@xleoken xleoken force-pushed the paimon-filesystem branch from 88f07f2 to 942dbde Compare June 27, 2024 09:28
zhoujinsong
zhoujinsong approved these changes Jun 28, 2024
View reviewed changes
Copy link
Contributor

@zhoujinsong zhoujinsong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@zhoujinsong zhoujinsong merged commit 97f299c into apache:master Jun 28, 2024
4 checks passed
@xleoken xleoken deleted the paimon-filesystem branch June 28, 2024 08:22
zhoujinsong pushed a commit that referenced this pull request Jul 11, 2024
@xleoken @zhoujinsong
[AMORO-2960] Support paimon s3 based catalog (#2972)
1e7c10b 
* [AMORO-2960] Support paimon s3 based catalog

* trigger ci
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhoujinsong zhoujinsong zhoujinsong approved these changes

@baiyangtx baiyangtx baiyangtx approved these changes

Assignees
No one assigned
Labels
module:ams-dashboard Ams dashboard module module:ams-server Ams server module module:core Core module type:build
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature]: Support paimon s3 based catalog
3 participants
@xleoken @zhoujinsong @baiyangtx